Last modified: 2011-06-05 23:43:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23346, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 21346 - Make deleted images searchable by hash (disabled in Miser Mode)


Summary:	Make deleted images searchable by hash (disabled in Miser Mode)

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	API (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Sam Reed (reedy)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	22744 27595
	Show dependency tree / graph

Reported:	2009-10-29 11:09 UTC by Maarten Dammers
Modified:	2011-06-05 23:43 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Maarten Dammers 2009-10-29 11:09:58 UTC

I use the search by hash option to prevent my bots from uploading duplicate images. The hash of a deleted image is available in filearchive.fa_storage_key in the form <sha1>.<extension>
It would be nice if the deleted images are searchable in the api. This way I can easily skip images already deleted.

Comment 1 Sam Reed (reedy) 2009-11-19 15:21:10 UTC

Hmmm

This looks like it might be fairly simple..

The functionality is there for normal images, its only a case of duplicating/reusing it on the filearchive table..

Comment 2 Sam Reed (reedy) 2010-01-11 13:05:45 UTC

Also needs to make sure rights are there...

Comment 3 Sam Reed (reedy) 2010-01-11 13:18:31 UTC

[13:15:37] <RoanKattouw> The filearchive thing is different altogether, and we can get away with putting that in its own module, cf. list=deletedrevs
[13:16:17] <RoanKattouw> And then there's prop=duplicatefiles, we may want to add a param for "search old versions too" there, not sure how to handle the results though (per the old-version-matches-but-current-version-returned problem)

Comment 4 Sam Reed (reedy) 2010-05-10 22:41:40 UTC

r66168

Comment 5 db [inactive,noenotif] 2011-03-07 19:41:12 UTC

removed with r83411

Comment 6 Sam Reed (reedy) 2011-06-05 23:41:11 UTC

Readded in r89542, but it's disabled in miser mode

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links