Last modified: 2014-04-06 08:00:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29302, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 27302 - RL: Avoid unnecessary and uncached requests for user and site modules


Summary:	RL: Avoid unnecessary and uncached requests for user and site modules

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	ResourceLoader (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Trevor Parscal

URL:	http://translatewiki.net
Whiteboard:
Keywords:

Depends on:
Blocks:	27339
	Show dependency tree / graph

Reported:	2011-02-10 13:08 UTC by P.Copp
Modified:	2014-04-06 08:00 UTC (History)
CC List:	3 users (show)

See Also:	63587
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Simple fix for OutputPage::makeResourceLoaderLink (714 bytes, patch) 2011-02-10 13:08 UTC, P.Copp	Details
Attaching the picture to the bug for posterity. (120.74 KB, image/png) 2011-02-19 14:16 UTC, Antoine "hashar" Musso (WMF)	Details
Add an attachment (proposed patch, testcase, etc.)

Description P.Copp 2011-02-10 13:08:07 UTC

Created attachment 8120 [details]
Simple fix for OutputPage::makeResourceLoaderLink

If a ResourceLoaderWikiModule (user or site) is empty, i.e. the relevant pages doesn't exist, there should be no link to it from the html to avoid unnecessary requests.

Currently, it doesn't only output the link, but also adds a version parameter with the current timestamp, which bypasses all caches. This is due to a bug in OutputPage::makeResourceLoaderLink, where the modifiedTimestamp of the module is rounded to 0 if it returns 1.

This bug occurs in the following circumstances:

* For the site module, if MediaWiki:Common.js and MediaWiki:<Skin>.js is empty.
* For the user css module, if not logged in.
* For the user js module, if logged in and the user js pages are empty.

Simple fix attached.

Comment 1 Roan Kattouw 2011-02-16 07:20:03 UTC

Timestamp issue fixed in r82219.

Comment 2 Roan Kattouw 2011-02-16 15:37:58 UTC

(In reply to comment #1)
> Timestamp issue fixed in r82219.
Wow, thanks for this report. It cut server load on the bits Apaches in half: http://file.status.net/i/identica/catrope-20110216T150241-xmvxh2t.png

Comment 3 Mark A. Hershberger 2011-02-16 22:46:10 UTC

Roan fixed this during the deploy.

Comment 4 Roan Kattouw 2011-02-18 17:26:46 UTC

(In reply to comment #3)
> Roan fixed this during the deploy.
No I didn't, only part of it. The timestamp issue was fixed, but the loading of the user module for users with no user JS/CSS (and anons!) persists.

Comment 5 Antoine "hashar" Musso (WMF) 2011-02-19 14:16:30 UTC

Created attachment 8173 [details]
Attaching the picture to the bug for posterity.

Comment 6 Roan Kattouw 2011-02-19 17:08:01 UTC

Fixed in r82468.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links