Last modified: 2012-05-09 01:30:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T29232, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 27232 - UploadWizard: Validation is broken?
UploadWizard: Validation is broken?
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks: 27260 36680
  Show dependency treegraph
 
Reported: 2011-02-08 01:44 UTC by Neil Kandalgaonkar
Modified: 2012-05-09 01:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-02-08 01:44:53 UTC
Validation appears not to be working at the details step. 

When the 'submit' button is clicked, any empty required fields or other fields that fail to pass their own validation criteria should trigger red error messages above the problematic fields. 

The wizard does seem to be aware that something is wrong because it refuses to go to the next step.
Comment 1 Neil Kandalgaonkar 2011-03-04 23:28:27 UTC
Validation isn't broken, but it can be better aligned with the new layout. Changing it to a non-critical bug, but we still want to do this before 1.0.
Comment 2 Ryan Kaldari 2011-03-04 23:41:10 UTC
Fixed in r83256.
Comment 3 Neil Kandalgaonkar 2011-03-17 01:25:39 UTC
Validation for multiple deeds doesn't seem to be working. 

* upload multiple files, 
* then select "pick copyright info individually" at release rights 
* try to submit details page without filling out deeds, should cause validation errors above deeds, but doesn't.
* other validation appears to be working, though.
Comment 4 Neil Kandalgaonkar 2011-03-17 01:30:23 UTC
Nice to have:
- if the validator listed the number of errors near the page submit button. 
- if the total number of errors, and the errors themselves, flashed yellow (and faded to white) every time one pressed submit.
Comment 5 Ryan Kaldari 2011-03-18 00:33:03 UTC
Fixed except for the nice-to-haves in r84216.
Comment 6 Neil Kandalgaonkar 2011-03-21 23:17:37 UTC
Since this is fixed, it's fixed. ;)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links