Last modified: 2011-03-27 20:13:42 UTC
So I went through the "Select a custom Creative Commons license" selector to pick CC-SA-unported and when I was clicked "continue" I was thrown back on the page with "Choose which Creative Commons license you want and click "proceed"." (never mind that I had clicked "proceed" in the CC picker).
Also it forgot which extensions I selected to have enabled so I had to re-choose them.
There were two things breaking this:
* X-Frame-Options forbade our final step of the license selector, or the license selection shower, from being loaded properly. This lead to it looking wrong.
* The installation URL fingerprinting broke on the long query string that's on the final step. As a result, the user's selection got saved into a different session subkey, thinking it belonged to a different installation. It would then not get seen by the surrounding page's installer instance, causing the confusion.
Fix removes the X-Frame-Options for the CC bit, and drops query strings before the rest of URL normalization in the fingerprint check so the CC bits now see the same session key as the rest.
Fixed in r84881.