Last modified: 2011-03-27 20:13:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 27170 - [Installer] Install does not complete when choosing a CC license
[Installer] Install does not complete when choosing a CC license
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.18.x
All All
: High normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks: 26676
  Show dependency treegraph
 
Reported: 2011-02-05 01:10 UTC by Mark A. Hershberger
Modified: 2011-03-27 20:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2011-02-05 01:10:46 UTC
So I went through the "Select a custom Creative Commons license" selector to pick CC-SA-unported and when I was clicked "continue" I was thrown back on the page with "Choose which Creative Commons license you want and click "proceed"." (never mind that I had clicked "proceed" in the CC picker).

Also it forgot which extensions I selected to have enabled so I had to re-choose them.
Comment 1 Brion Vibber 2011-03-27 20:13:42 UTC
There were two things breaking this:
* X-Frame-Options forbade our final step of the license selector, or the license selection shower, from being loaded properly. This lead to it looking wrong.
* The installation URL fingerprinting broke on the long query string that's on the final step. As a result, the user's selection got saved into a different session subkey, thinking it belonged to a different installation. It would then not get seen by the surrounding page's installer instance, causing the confusion.

Fix removes the X-Frame-Options for the CC bit, and drops query strings before the rest of URL normalization in the fingerprint check so the CC bits now see the same session key as the rest.

Fixed in r84881.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links