Last modified: 2012-05-08 13:54:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26306 - Cleanup extensions that include jquery (and common plugins) themselves
Cleanup extensions that include jquery (and common plugins) themselves
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 26307 29099
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2010-12-11 23:06 UTC by Sam Reed (reedy)
Modified: 2012-05-08 13:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-12-11 23:06:12 UTC
We should really look at cleaning up extensions that include jquery themselves

Quick look at the extensions directory, there are various inclusions if jquery 1.3.2, 1.4.2, 1.7.1, 1.7.2, 1.8

And then other plugins, oddities and numerous other things

20 folders, 326 other items..

MW svn head has for a while included Jquery for a while, and therefore only conditional inclusion is needed for those that care for back compatibility back to the stone age (*cough*)
Comment 1 Krinkle 2010-12-11 23:18:35 UTC
Just so you know, jQuery !== jQuery UI.
Versions 1.7.1, 1.7.2, 1.8 are not versions of jQuery but of jQuery UI.
Although a big one, "jQuery UI" is 'just' a plugin, just like jQuery.cookie for example.
Dont confuse one with the other when cleaning up :)
Comment 2 Sam Reed (reedy) 2010-12-11 23:34:30 UTC
Yeah.. I was just looking at that, and then pressed submit by accident ;)

Tweak title a bit
Comment 3 Roan Kattouw 2010-12-12 12:10:22 UTC
Still, jQuery UI is in core too and shouldn't be included by extensions either (unless they're trying for 1.16 b/c and properly using RL in 1.17).
Comment 4 Krinkle 2010-12-12 12:38:32 UTC
Hence Reedy changed the summary to include "(and common plugins)", which I guess means anything in /resources/ by default.
Comment 5 Brion Vibber 2011-05-10 21:35:06 UTC
OpenID had a copy of jQuery 1.3.2 & jquery.cookie; I've converted it to use ResourceLoader and MW's stock jquery modules in r87845. (Also removed a manually-maintained sprite by switching to icon embedding in the CSS, yay!)
Comment 6 Brion Vibber 2011-05-10 21:53:35 UTC
Collection ext in r87847: stray copies of jquery, jquery.ui, and jquery.json.

jquery & jquery.ui copies here were unused -- already replaced with references to core loaded via RL.
jquery.json is also available in core, so switched to using the core copy of that too.
Comment 7 DieBuche 2011-05-12 09:02:43 UTC
WikiBhasha is affected as well.
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87245
Comment 8 Sam Reed (reedy) 2011-05-23 00:40:54 UTC
Ouch, we've got inclusions of versions 1.2.2 and 1.3.1 of jQuery....

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links