Last modified: 2013-06-18 15:09:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31099, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29099 - Remove all jquery/js files that already exist in core
Remove all jquery/js files that already exist in core
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
Depends on:
Blocks: 26306
  Show dependency treegraph
 
Reported: 2011-05-22 22:05 UTC by Sam Reed (reedy)
Modified: 2013-06-18 15:09 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-05-22 22:05:31 UTC
UW is probably one of the worst "offenders" of this. Granted, some are needed to work with the older versions, but any that are in at least 1.17 should be cleaned up

Like the datepicker files, among many others :)
Comment 1 Sam Reed (reedy) 2011-05-22 23:36:45 UTC
r88610, r88611, r88612, r88613, r88614, r88615, r88616, r88617, r88618, r88621
Comment 2 Sam Reed (reedy) 2011-12-08 20:18:14 UTC
Tipsy is in core, and has been for a while. I guess that's another candidate to strip from UW :). Not sure what the difference between version 1.0.0a and version 1.0.0a+ is. Maybe someone could tidy that up and remove from UW? Even if the UW version replaces the core one

Spinner can also go away with 1.19 (it's in phase3)

jquery.autocomplete could probably be pulled straight into core
Comment 3 Ian Baker 2011-12-08 21:47:35 UTC
While we're at it, the JS wikitext parser is another good candidate for something to roll into core.  It's in the jQueryMsg extension (though that version is a little out-of-date), but should really not be an extension at all.
Comment 4 Sam Reed (reedy) 2011-12-08 21:49:31 UTC
(In reply to comment #3)
> While we're at it, the JS wikitext parser is another good candidate for
> something to roll into core.  It's in the jQueryMsg extension (though that
> version is a little out-of-date), but should really not be an extension at all.

{{BeBold}} && {{JFDI}} :D

Seems relatively simple and standalone

As long as files are svn copied in, all should be well
Comment 5 Neil Kandalgaonkar 2011-12-08 21:57:23 UTC
Yeah, also I want to use some libraries from UW in the VisualEditor thing so I'm moving quite a few of them out right now.

Reedy: svn copy and not svn move?
Comment 6 Sam Reed (reedy) 2011-12-12 14:47:27 UTC
(In reply to comment #5)
> Yeah, also I want to use some libraries from UW in the VisualEditor thing so
> I'm moving quite a few of them out right now.
> 
> Reedy: svn copy and not svn move?

As per IRC, svn move is fine (as it's svn copy && svn delete)

(In reply to comment #3)
> While we're at it, the JS wikitext parser is another good candidate for
> something to roll into core.  It's in the jQueryMsg extension (though that
> version is a little out-of-date), but should really not be an extension at all.

See bug 32979, seems we have a core module dependent on extensions :(
Comment 7 Sam Reed (reedy) 2012-05-04 23:52:19 UTC
Looks like this is in reasonable shape now..

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links