Last modified: 2013-06-18 16:29:08 UTC
CR sometimes sends secure server links in its updates, this is apparently cased depending on where the person is viewing from (aka the server server). Although this isn't a major thing, it can be a pain if the person doesn't normally use the secure server.
Created attachment 7902 [details] Screenshot
Yeah, I have this almost always. I actually thought it was itentionally the default behaviour to recieve https links, but I normally login at home usung http. Would be nice to get the urls per mail also that way so I'm logged already.
(In reply to comment #2) > Yeah, I have this almost always. That's probably because most of the comments and follow-ups you get are from me ;)
This also happens with LQT.
*** Bug 26606 has been marked as a duplicate of this bug. ***
I missed this dupe and filed bug 26606 because this isn't in the "MW extensions/CodeReview" component. The CR and LQT elements of this should be filed as separate bugs.
(In reply to comment #6) > I missed this dupe and filed bug 26606 because this isn't in the "MW > extensions/CodeReview" component. The CR and LQT elements of this should be > filed as separate bugs. No, because they use the core services to send the email. No point in creating multiple instances of the same code in different extensions when the main issue could just be worked on.
Hmm, maybe. But how to incorporate this WMF-specific feature into the general codebase?
Can I suggest an alternate view of how this bug may be fixed. There seems no ability to control whether changes to pages are sent with normal (http) or secure (https) urls. Numbers of people operate in the https zone by default and it would be useful to received secure urls be default. I am wondering whether there is the ability to set within users' MW preferences the choice of receiving urls in one form or the other. Similarly it would be useful for this to be a global default if possible, rather than to have be set per wiki.
It'd be cool if we could have different linker objects, one for making canonical links for things going out to emails, or irc channels (comments around the code for irc RC notices seem to indicate weird black magic is going on...), and then a different linker object for normal links that'd appear on site.
Duping this to older bug 19429; bug 29878 suggests similar to mentioned above in comment 9 (allow users to configure their ssl vs non-ssl preference, and send links based on the recipient's setting). Comment 10 is mostly covered by addition of Title::getCanonicalUrl() and pals... which should also mostly cover the bas bug 19429, but only if it's actually used. :) *** This bug has been marked as a duplicate of bug 19429 ***
Actually, I'm de-duping this one and making bug 19429 a dupe of bug 29878.
*** This bug has been marked as a duplicate of bug 29878 ***
