Last modified: 2014-05-29 20:09:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 25647 - TIFF images that are too big to thumbnail don't display errors on image page
TIFF images that are too big to thumbnail don't display errors on image page
Status: RESOLVED DUPLICATE of bug 52045
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: 24984 (view as bug list)
Depends on: 52045
Blocks: tiff-handling
  Show dependency treegraph
Reported: 2010-10-25 20:31 UTC by Derk-Jan Hartman
Modified: 2014-05-29 20:09 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Derk-Jan Hartman 2010-10-25 20:31:51 UTC
I've been confused for a while on why some files return a HTML version of an error, and others a textual version.

For instance: returns an HTML error and an image url. (the image contains the error report as well, but that is not the point really).

I cannot determine what the difference is between the two render methods. Clearly in one case we get the toHtml of ThumbnailImage class and in the other of MediaTransformError class, but
Comment 1 Mark A. Hershberger 2011-04-02 03:12:17 UTC
For those chasing this down: the first URL returns "Error creating thumbnail: Invalid thumbnail parameters or PNG file with more than 12.5 million pixels"

The second URL shows the alt-text for the image but no image.  Right clicking and selecting "view image".  A squid error page is shown then with this text:

  While trying to retrieve the URL:

  The following error was encountered:

      Unable to forward this request at this time. 
  Generated Sat, 02 Apr 2011 03:05:42 GMT by

So, in the second case there is a squid error for some reason.  Perhaps the thumbnail failed but MW wasn't informed of the failure.  The first image just doesn't get thumbnailed because, as the message says, the image was too big.
Comment 2 p858snake 2011-04-02 03:57:28 UTC
-shell. No explation given for its needness.
Comment 3 Bawolff (Brian Wolff) 2011-04-04 17:05:40 UTC
Presumably the png is failing the $wgMaxImageArea check in the Bitmap image handler, (normaliseParams is returning false, which is checked before TRANSFORM_LATER, thus the error is known at the time when the page is rendered). In Paged Tiff Handler, the equivalent check is done towards the end of the doTransform method (after the self::TRANSFORM_LATER check), so the error is only encountered when the 404 handler tries to make the thumbnail, not at page render time.
Comment 4 Mark A. Hershberger 2011-04-04 17:16:18 UTC
Looks like the squid error was part of the thumbnail backlog.  The tif.jpg url now gives:

  Error generating thumbnail

  Error creating thumbnail: The resolution of the source file is too large.
  No thumbnail will be generated. 

So bawolff was right.  It seems like some preliminary checks (like "Is this image too big?") would be useful.
Comment 5 Michael Dale 2011-04-04 19:20:17 UTC
maybe take into consideration bug 28135 for future large tiff support
Comment 6 Thehelpfulone 2012-06-22 19:41:14 UTC
Reassigning to wikibugs-l per bug 37789
Comment 7 matanya 2012-08-14 01:22:27 UTC
*** Bug 24984 has been marked as a duplicate of this bug. ***
Comment 8 Bawolff (Brian Wolff) 2012-08-14 12:05:55 UTC
Changing status Assigned -> New, since it is assigned to wikibugs-l...
Comment 9 Greg Grossmeier 2013-07-25 19:02:26 UTC
All 3 urls mentioned in this report work for me today.

Can someone provide example TIFFs that *don't* work as expected? VipsScaler might be a solution to this problem.
Comment 10 Bawolff (Brian Wolff) 2013-07-25 19:32:59 UTC
Here's some:
MariaDB [commonswiki_p]> select img_name from image where img_media_type= 'BITMAP' and img_major_mime = 'image' and img_minor_mime = 'tiff' and img_width*img_height > 60000000 limit 20;
| img_name                                                                                                              |
| 19F_chemical_shifts.tif                                                                                               |
| 255-CC-65-HC-223,_back.tif                                                                                            |
| 255-CC-65-HC-223.tif                                                                                                  |
| A_street_in_yorktown_va.tif                                                                                           |
| Bathing_beauties_dancing_on_Washington_beach-t.tif                                                                    |
| Bill_of_Rights.tif                                                                                                    |
| Boylston_Street_and_the_Public_Garden,_showing_subway_entrance,_Boston,_Mass..tif                                     |
| Buffalo_Light_House_-_00001a.tiff                                                                                     |
| Buffalo_Light_House_-_00002a.tiff                                                                                     |
| Buffalo_Light_House_-_00003a.tiff                                                                                     |
| Buffalo_Light_House_-_00004a.tiff                                                                                     |
| Buffalo_Light_House_-_00005a.tiff                                                                                     |
| Buffalo_Light_House_-_00006a.tiff                                                                                     |
| Buffalo_Light_House_-_00007a.tiff                                                                                     |
| Buy_Your_Victory_Bonds._Color_poster._Issued_by_Victory_Bond_Committee,_Ottawa,_Canada.,_ca._1917_-_NARA_-_516338.tif |
| Capitol_statuary_hall.tif                                                                                             |
| Christ_Church_(Cambridge,_Massachusetts)_-_00000a.tif                                                                 |
| Christ_Church_(Cambridge,_Massachusetts)_-_00001a.tif                                                                 |
| Christ_Church_(Cambridge,_Massachusetts)_-_00002a.tif                                                                 |
| Christ_Church_(Cambridge,_Massachusetts)_-_00003a.tif                                                                 |

VIPS can be a soltion, but at the moment we don't have code to selectively do it only for bug tiffs (yet).

Of course this bug is more about max image area being checked at image render time instead of page parse time.
Comment 11 Derk-Jan Hartman 2013-07-25 20:22:23 UTC
And a handy category to remember:

I'm doing some purges now btw. It seems they are pretty taxing on the system, I think I just dos'ed the thumbnailing server for a few seconds. :(
Comment 12 Bawolff (Brian Wolff) 2013-07-25 21:10:35 UTC
(In reply to comment #11)
> And a handy category to remember:
> I'm doing some purges now btw. It seems they are pretty taxing on the
> system, I
> think I just dos'ed the thumbnailing server for a few seconds. :(

Btw, for thumbnails that are broken, purging is probably unnessary as we retry on every page view afaik
Comment 13 Marco 2013-10-05 21:42:16 UTC
Someone please mark this bug as Resolved_Duplicate of bug 52045
(bug 52045 has a Patch to review which solves this issue)
Comment 14 Mark A. Hershberger 2013-10-05 23:52:21 UTC

*** This bug has been marked as a duplicate of bug 52045 ***

Note You need to log in before you can comment on or make changes to this bug.