Last modified: 2014-11-08 16:10:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T16892, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 14892 - Linkify plain external links in revision editsummary and log reason
Linkify plain external links in revision editsummary and log reason
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Low enhancement with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 8321 13205 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-23 01:05 UTC by TheEvilSpartan
Modified: 2014-11-08 16:10 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description TheEvilSpartan 2008-07-23 01:05:04 UTC
Sometimes an edit summary or block log will contain a link to a diff or other Wikimedia page that cannot be accessed through a wikilink. Wikimedia software does not allow external links; presumably for spam reasons; however, if the link is internal, it should be allowed (just as wikilinks are allowed). An example of where this would have been useful is http://en.wikipedia.org/w/index.php?title=Special:Log&type=block&page=User:Light%20current (search for "http").

I imagine that for sites not affiliated with Wikimedia, one might allow internal sites or other sites, with an option to allow or disallow. Perhaps an "opt-in" list for legal sites? Second part optional to first part.
Comment 1 Siebrand Mazeland 2008-08-11 11:00:00 UTC
Changed summary from "Allow hyperlinks in edit summary/block log when it's to a Wikimedia page" to "Allow whitelisted external hyperlinks in edit summary/block log".
Comment 2 Mike.lifeguard 2008-12-02 20:28:45 UTC
(In reply to comment #0)
> Sometimes an edit summary or block log will contain a link to a diff or other
> Wikimedia page that cannot be accessed through a wikilink. Wikimedia software
> does not allow external links; presumably for spam reasons; however, if the
> link is internal, it should be allowed (just as wikilinks are allowed). An
> example of where this would have been useful is
> http://en.wikipedia.org/w/index.php?title=Special:Log&type=block&page=User:Light%20current
> (search for "http").
> 
> I imagine that for sites not affiliated with Wikimedia, one might allow
> internal sites or other sites, with an option to allow or disallow. Perhaps an
> "opt-in" list for legal sites? Second part optional to first part.
> 

I'm pretty sure you can use links in log entries and edit summaries. They are not actual links though. Is that what you're requesting? If so, all links should be actual links (and blacklisted domains will not be permitted of course).
Comment 3 Helder 2009-07-05 11:54:23 UTC
I'm also interested in having the links in summaries as "actual links". This is usefull when we are linking to a diff or to a specific revision of a page in the same project (or in other Wikimedia projects). For example, the summary of the following revisions should be an actual link:
http://pt.wikibooks.org/w/index.php?title=MediaWiki:Edittools&curid=18840&diff=131023&oldid=130996
(note: I've used the wiki code
commons:MediaWiki:Edittools|MediaWiki%3AEdittools]]&diff=23178727&oldid=22539783">http://commons.wikimedia.org/w/index.php?title=[[commons:MediaWiki:Edittools|MediaWiki%3AEdittools]]&diff=23178727&oldid=22539783
but this is not a link to what I wanted [the specific revision])
and
http://pt.wikibooks.org/w/index.php?title=Wikilivros:Caixa_de_areia&diff=prev&oldid=130117

So, I think at least links to Wikimedia projects could be actual links.

Comment 4 Mike.lifeguard 2009-07-05 21:05:27 UTC
There's no reason this should be only whitelisted domains. Unless blacklisted, any domain should be allowed.
Comment 5 TheEvilSpartan 2009-07-05 22:21:02 UTC
(In reply to comment #4)
> There's no reason this should be only whitelisted domains. Unless blacklisted,
> any domain should be allowed.
> 
My worries would be spam; this could not be undone. I guarantee you you'd rather not see the consequences once the Hagger vandal started linking to http://test.on.nimp.org (hint: absolutely DO NOT visit that link unless you have an easy stomach and have javascript disabled or the ctrl-alt-del button ready). Just saying about blacklisted sites... might want to have a chat with community about this first.

Again, though, there's no reason to exclude whitelisted sites.
Comment 6 Mike.lifeguard 2009-07-06 00:42:40 UTC
That domain is blacklisted and has been for a very long time. Though, I do see your point - with pages we can edit to remove links we don't want - not so for edit summaries and log reasons. Perhaps I was hasty on that point.
Comment 7 Gurch 2009-07-06 09:27:51 UTC
I don't see the value in external links. I do see the value in *internal* links to things that currently can only be linked to "externally" because there is no syntax for linking to them internally. But I consider that an issue that should be fixed by adding such a syntax, and then allowing *that* in summaries, not by permitting external links in summaries.
Comment 8 Gurch 2009-07-06 09:30:12 UTC
(In reply to comment #6)
> with pages we can edit to remove links we don't want - not so for
> edit summaries and log reasons.

Well, it is so, but only for the powers that be.

I think the rest of us prefer our edit histories without every other summary censored for our protection, though, which is why I'm opposed to allowing external links there.
Comment 9 Helder 2009-07-06 10:10:13 UTC
(In reply to comment #7)
> I don't see the value in external links. I do see the value in *internal* links
> to things that currently can only be linked to "externally" because there is no
> syntax for linking to them internally. But I consider that an issue that should
> be fixed by adding such a syntax, and then allowing *that* in summaries, not by
> permitting external links in summaries.
> 
I agree.

Maybe we could use the same sintax of the magic words 'fullurl' and 'filepath'
http://www.mediawiki.org/wiki/Help:Magic_words#URL_data

because codes like
{{fullurl:w:pt:Wikipedia:A enciclopédia livre|action=edit&oldid=15930217}}
are shorter than the "external link" form
http://pt.wikipedia.org/w/index.php?title=Wikipedia:A_enciclop%C3%A9dia_livre&action=edit&oldid=15930217
Comment 10 Mike.lifeguard 2009-07-06 19:22:33 UTC
(In reply to comment #7)
> I do see the value in *internal* links
> to things that currently can only be linked to "externally" because there is no
> syntax for linking to them internally.

Agreed - I think there is an open bug report for that, but I can't immediately find it.

(In reply to comment #8)
> (In reply to comment #6)
> > with pages we can edit to remove links we don't want - not so for
> > edit summaries and log reasons.
> 
> Well, it is so, but only for the powers that be.

Unless you're talking about sysadmins manually editing the database, that's not true. There's no way to do it from inside the software.
Comment 11 Alexandre Emsenhuber [IAlex] 2009-08-24 20:25:16 UTC
*** Bug 13205 has been marked as a duplicate of this bug. ***
Comment 12 Alexandre Emsenhuber [IAlex] 2009-08-24 21:16:15 UTC
*** Bug 8321 has been marked as a duplicate of this bug. ***
Comment 13 The Evil IP address 2009-12-24 15:21:06 UTC
Suggestion: While I wouldn't want external links in the edit summary, but I think it would be great if links with {{fullurl:}} could work in the edit summary. This would allow to easily link stuff within the own wiki and some of the interwikis, but not make it possible to link spam in the edit summary. 
Comment 14 Bergi 2010-09-04 19:16:24 UTC
I also think this feature would be great. It is requested frequently by the German Wikipedia community.
In my opinion the usual link form with http:// should be supported as well as the {{fullurl:, because it easier works with c&p. I dont think the length of the link matters, as far as you dont type it manually :-)

Another question would be whether the feature should work with already existing log entries. Is that possible?
Comment 15 Krinkle 2011-02-13 00:32:03 UTC
(In reply to comment #13)
> Suggestion: While I wouldn't want external links in the edit summary, but I
> think it would be great if links with {{fullurl:}} could work in the edit
> summary. This would allow to easily link stuff within the own wiki and some of
> the interwikis, but not make it possible to link spam in the edit summary. 

That would most likely require running all core parsers. Not sure if using parser functions like {{fullurl:}} should be parsed. I would vote "No", since they are often used in summaries to perhaps explain things.
The last thing we want is having to use <nowiki> in an edit summary.

(In reply to comment #6)
> That domain is blacklisted and has been for a very long time. Though, I do see
> your point - with pages we can edit to remove links we don't want - not so for
> edit summaries and log reasons. Perhaps I was hasty on that point.

True, the edit summary can't be edited. So perhaps we should only allow external links in log entries (which limites the exposure) and not in edit summaries.

On the other hand, now that RevisionDelete is well-integrated. This would be a great usecase for the sysop version of revisiondelete (hiding an edit summary that contains spam).

So parsing plain external links (ie. not [http://link linktext] but just plain simple external links) in all edit summaries and external links is a good idea imho. (Just like normal [[links]] are parsed as well)
Comment 16 Gerrit Notification Bot 2013-05-12 22:25:15 UTC
Related URL: https://gerrit.wikimedia.org/r/63395 (Gerrit Change I77fdaf8e04375caa1d67ca4a3ec3bd93920c3309)
Comment 17 Tim Weyer 2014-01-05 01:42:14 UTC
You can use Special:PermanentLink/revisionId. It even looks prettier than the hole url. But complete urls are required in some cases and making them active links (only whitelisted) can be useful.
Comment 18 Gerrit Notification Bot 2014-11-08 06:16:04 UTC
Change 172017 had a related patch set uploaded by MZMcBride:
Make free-form external links clickable in edit summaries

https://gerrit.wikimedia.org/r/172017
Comment 19 Nemo 2014-11-08 06:47:56 UTC
Note, the summary's is a parsing level used in many other places, including extensions.

(In reply to Tim Weyer from comment #17)
> making them
> active links (only whitelisted) can be useful.

What whitelists could one use? The current site? Interwiki map?  $wgNoFollowDomainExceptions?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links