Last modified: 2012-08-04 20:48:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12779 - Bad query when viewing difference
Bad query when viewing difference
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.11.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks: postgres
  Show dependency treegraph
 
Reported: 2008-01-24 18:36 UTC by Chris Bandy
Modified: 2012-08-04 20:48 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch against 1.11.1 (543 bytes, patch)
2008-01-24 18:37 UTC, Chris Bandy
Details

Description Chris Bandy 2008-01-24 18:36:21 UTC
In DifferenceEngine.showDiffPage, a timestamp is passed as a database condition in TS_MW format.


A database error has occurred Query: SELECT * FROM recentchanges WHERE rc_timestamp = '20080124171514' AND rc_this_oldid = '2' AND rc_last_oldid = '1' AND rc_patrolled = '0' Function: DifferenceEngine::showDiffPage Error: 1 ERROR: invalid input syntax for type timestamp with time zone: "20080124171514"

Backtrace:

#0 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/Database.php(796): DatabasePostgres->reportQueryError('ERROR: invalid...', 1, 'SELECT * FROM...', 'DifferenceEngin...', false)
#1 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/Database.php(1241): Database->query('SELECT * FROM...', 'DifferenceEngin...')
#2 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/RecentChange.php(100): Database->select('recentchanges', '*', Array, 'DifferenceEngin...')
#3 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/DifferenceEngine.php(178): RecentChange::newFromConds(Array, 'DifferenceEngin...')
#4 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/Article.php(674): DifferenceEngine->showDiffPage(false)
#5 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/Wiki.php(383): Article->view()
#6 /srv/www/htdocs/wikidev/mediawiki-1.11.1/includes/Wiki.php(48): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#7 /srv/www/htdocs/wikidev/mediawiki-1.11.1/index.php(89): MediaWiki->initialize(Object(Title), Object(OutputPage), Object(User), Object(WebRequest))
#8 {main}
Comment 1 Chris Bandy 2008-01-24 18:37:34 UTC
Created attachment 4578 [details]
patch against 1.11.1

Fixes for me on Postgres 8.1.9 and MediaWiki 1.11.1
Comment 2 Roan Kattouw 2008-01-24 20:06:13 UTC
This was fixed 4 months ago in r25696. 1.12 will behave correctly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links