Last modified: 2008-08-11 23:44:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4926 - <noinclude></noinclude> section is transcluded when used by system messages
<noinclude></noinclude> section is transcluded when used by system messages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.7.x
All All
: Normal minor with 7 votes (vote)
: ---
Assigned To: Brion Vibber
:
: 5721 6429 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-09 03:00 UTC by Borgx
Modified: 2008-08-11 23:44 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Borgx 2006-02-09 03:00:47 UTC
<noinclude></noinclude> section not included when transcluded into
MediaWiki:foo, but included when the MediaWiki:foo message used by mw in their
proper function.

for example:
1. Template:test => sometext <noinclude>comments</noinclude>
2. Put {{test}} to MediaWiki:Recentchangestext => sometext
3. go to Special:recentchanges, it displayed => sometext comments
Comment 1 Rob Church 2006-04-26 09:14:55 UTC
*** Bug 5721 has been marked as a duplicate of this bug. ***
Comment 2 Brion Vibber 2006-06-09 20:41:21 UTC
Probably related to bug 6077.
Comment 3 Brion Vibber 2006-06-10 00:02:20 UTC
I've added test cases for this in r14694, but haven't made the 
fix yet until we have a better idea of what needs to be done 
with message transforms.

It may make the most sense to simply not do any template 
transclusions in message transformation; wikitext messages will 
then do the transclusion at parse time.
Comment 4 Brion Vibber 2006-06-24 21:05:37 UTC
*** Bug 6429 has been marked as a duplicate of this bug. ***
Comment 5 Michael 2006-06-25 20:35:12 UTC
I notice something similar and filed Bug 6429, which was marked a duplicate of
this bug.  I thought I would add my experience and test cases here to see if it
could help squash this bug.  Thanks
----
I have found that text placed in <noinclude> tags in templates will show up
anyway when transclued in the Sitenotice. See my beta wiki for an example:
http://beta.theplaz.com/index.php?title=MediaWiki:Sitenotice.

You can see in the sitenotice on every page at beta.theplaz.com that the
noinclude text got transcluded anyway.
My sitenotice calls http://beta.theplaz.com/index.php?title=Template:This_Template

When I view the regular sitenotice page (MediaWiki:Sitenotice) the text in the
noinclude does not appear. This way I know that I used the noinclude properly.
I know I am using an old version of MW, but I searched and didn't see it fixed
in 1.6.7.

-Michael
http://theplaz.com
Comment 6 Michael 2006-07-01 10:58:05 UTC
I just noticed something else related to this bug.  It seems that the problem
goes away when the content is double transcluded.  As above, I have
[[Template:This Template]], I then created [[Template:Middleman]] and had that
transclude {{This Template}}.  I then  switched the sitenotice to transclude
{{Middleman}} instead.  The text in the noinclude is no longer transcluded. 
This seems to be a working work-around that editors can use to temporary resolve
this problem.  Can someone confirm this for me?  Thanks.

-Michael
http://theplaz.com
http://beta.theplaz.com/index.php?title=MediaWiki:Sitenotice
http://beta.theplaz.com/index.php?title=Template:This_Template
http://beta.theplaz.com/index.php?title=Template:Middleman
Comment 7 omniplex 2006-07-07 23:07:40 UTC
Out of curiosity I tested it with the "preload" feature
explained on [[Help:Inputbox]], and there the behaviour
is different:

http://meta.wikimedia.org/wiki/abc?action=edit&preload=Template:Preload_demo/1
This gets Preload_demo/1 as is with the <noiclude> part.
http://meta.wikimedia.org/wiki/abc?action=edit&preload=Template:Preload_demo/2
This gets Preload_demo/2 as is, no "middleman" workaround
for "preload". The <includeonly> workaround combined with
parser functions can emulate <noinclude> for "preload".
Comment 8 Brion Vibber 2008-08-11 23:44:42 UTC
This seems to have been fixed some time ago by the new parser:

Reading tests from "maintenance/parserTests.txt"...
Running test pre-save transform: <noinclude> in subst (bug 3298)... PASSED
Running test pre-save transform: <onlyinclude> in subst (bug 3298)... PASSED
Running test message transform: <noinclude> in transcluded template (bug 4926)... PASSED
Running test message transform: <onlyinclude> in transcluded template (bug 4926)... PASSED

Resolving FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links