Last modified: 2013-06-18 16:05:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11586 - Enable CommentPages extension on English Wikinews
Enable CommentPages extension on English Wikinews
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Low enhancement with 5 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikinews.org/wiki/Wikinews:...
: patch-need-review
Depends on:
Blocks: 31235
  Show dependency treegraph
 
Reported: 2007-10-07 03:12 UTC by Zachary Hauri
Modified: 2013-06-18 16:05 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Zachary Hauri 2007-10-07 03:12:55 UTC
Hello,

I wrote a hook for SkinTemplateTabs that would add the comment tab, which is currently done using javascript. This would also use the new Comments namespace we had setup in bug 11471.

What the hook does is:
 * On pages in the Comments namespace, it removes the tab for the Comments_talk page, and adds tabs for the Talk and Main namespace
 * On pages in the Talk and Main namespace, it adds a tab for the Comments page.

The advantage to this is that it would also appear for visitors who cannot or do not use javascript. It would require some CSS changes to work with the monobook skin, which is filed separately as bug 11571. The changes would group the comments tab with the main and talk tabs instead of the edit/history/etc tabs.

More of the technical information is at http://www.mediawiki.org/wiki/User:Zachary/CommentPages, including source and setup.
Comment 1 Paul Williams 2008-01-24 19:24:43 UTC
This has reached community consensus at http://en.wikinews.org/wiki/Wikinews:Water_cooler/technical#Comment_tab_extension

The Comments: namespace is quite a well-used item in Wikinews. This extension will obviously do the job better than the JS hack we use right now.
Comment 2 Zachary Hauri 2008-02-13 22:21:18 UTC
This extension is now on the MediaWiki SVN: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CommentPages/

It just needs to be enabled on the English Wikinews.
Comment 3 Matt 2008-04-28 09:20:18 UTC
What's the main holdup on this? Can we get this enabled sometime soon? (need-review is because I was told the code still needs reviewing by someone)
Comment 4 Mike.lifeguard 2009-03-19 17:52:33 UTC
(In reply to comment #3)
> What's the main holdup on this? Can we get this enabled sometime soon?
> (need-review is because I was told the code still needs reviewing by someone)
> 

Yep, and until it is reviewed, there's nothing to do on shell, so I've removed that keyword.
Comment 5 Brion Vibber 2009-03-19 18:14:13 UTC
Assigning to myself for review.
Comment 6 Bawolff (Brian Wolff) 2011-02-17 01:17:56 UTC
btw, removing need-review keyword for now since this extension is not compatible with trunk. (or at least, it didn't work when i tested it).
Comment 7 p858snake 2011-05-22 08:20:16 UTC
+need-review so this shows in the relevant lists, doesn't really matter its brokeness
Comment 8 MZMcBride 2012-07-17 20:40:45 UTC
Chad and/or Reedy: can we get this extension (CommentPages) moved into Git, please?
Comment 9 Chad H. 2012-07-17 20:43:41 UTC
Please add it to the list: https://www.mediawiki.org/wiki/Git/Conversion/Extensions_queue

I will be processing all outstanding migration requests this week.
Comment 10 Nemo 2012-08-10 20:51:46 UTC
(In reply to comment #8)
> Chad and/or Reedy: can we get this extension (CommentPages) moved into Git,
> please?

Done in the meanwhile, now needs review.
Comment 11 Bawolff (Brian Wolff) 2012-08-13 12:10:49 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > Chad and/or Reedy: can we get this extension (CommentPages) moved into Git,
> > please?
> 
> Done in the meanwhile, now needs review.

Fixing the extension so it actually works would probably be a step that should be done prior to review (or you know, the review won't last very long).
Comment 12 Sumana Harihareswara 2012-11-16 22:16:18 UTC
I'm closing this bug this "invalid" because it looks pretty clear that the extension author will not be revising the extension to make it deployable.  It is in Git in case Zachary or someone else would like to improve it:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommentPages.git;a=summary

I'm very sorry for the original delay in response, Zachary.  If you'd like to work on improving communications mechanisms within Wikimedia projects I would like to bring your attention to a few new projects that could use your help:

https://www.mediawiki.org/wiki/Flow

https://www.mediawiki.org/wiki/Echo_%28Notifications%29

Thanks for your work on this and your contributions to Wikimedia projects.  Again, my apologies on the delay in review.
Comment 13 MZMcBride 2012-11-17 02:01:12 UTC
(In reply to comment #12)
> I'm closing this bug this "invalid" because it looks pretty clear that the
> extension author will not be revising the extension to make it deployable.  It
> is in Git in case Zachary or someone else would like to improve it:

The underlying issue here isn't resolved, but rather than re-open this bug, I forked it to bug 42214: "Opinions" tab on the English Wikinews currently uses a JavaScript implementation when it shouldn't.

(I guess cloning a Bugzilla bug doesn't leave a Bugzilla comment. A bit strange, in my opinion.)
Comment 14 MZMcBride 2012-11-17 20:24:48 UTC
(In reply to comment #13)
> The underlying issue here isn't resolved, but rather than re-open this bug, I
> forked it to bug 42214: "Opinions" tab on the English Wikinews currently uses a
> JavaScript implementation when it shouldn't.

This is a dupe of bug 13228 ("Adding custom inter-namespace tabs").

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links