Last modified: 2013-06-18 16:21:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44214, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 42214 - "Opinions" tab on the English Wikinews currently uses a JavaScript implementation when it shouldn't
"Opinions" tab on the English Wikinews currently uses a JavaScript implementa...
Status: RESOLVED DUPLICATE of bug 13228
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 31235
  Show dependency treegraph
 
Reported: 2012-11-16 23:57 UTC by MZMcBride
Modified: 2013-06-18 16:21 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2012-11-16 23:57:09 UTC
Forking (cloning) this bug from bug 11586, as bug 11586 was marked as invalid.

The underlying issue here is that on sites such as <https://en.wikinews.org/> there is an "Opinions" tab on individual news articles that leads to a Comments namespace page for each article. For example, <https://en.wikinews.org/wiki/Israel_launches_airstrikes_against_Gaza_Strip,_kills_Hamas_commander> has an "Opinions" tab at the top of the page that leads to <https://en.wikinews.org/wiki/Comments:Israel_launches_airstrikes_against_Gaza_Strip%2C_kills_Hamas_commander>.

This tab is currently implemented using JavaScript when it should be available in the native HTML output of the page. JavaScript should not be necessary to add this tab to the interface.

I'm marking this bug as "easy" as it really shouldn't be more than an hour's worth of work to get this extension fixed up and ready for review and deployment. If anyone is looking to get his or her name on "Special:Version", this is your chance!

Source code is here: <https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommentPages.git;a=summary>.
Comment 1 Bawolff (Brian Wolff) 2012-11-17 00:06:49 UTC
> I'm marking this bug as "easy" as it really shouldn't be more than an hour's
> worth of work to get this extension fixed up and ready for review and
> deployment. If anyone is looking to get his or her name on "Special:Version",
> this is your chance!
> 
> Source code is here:
> <https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommentPages.git;a=summary>.

The skinning system has changed significantly since then. The work required may be a "rewrite" of the extension, not a minor bug fix. Nonetheless not a huge amount of work and I agree with your assessment that this is an "easy" bug.

A main benefit to an extension (over current situation) would probably be not having an extra ajax request to determine if the tab should be red or not on almost every page view.
Comment 2 MZMcBride 2012-11-17 00:13:03 UTC
(In reply to comment #1)
> The skinning system has changed significantly since then. The work required may
> be a "rewrite" of the extension, not a minor bug fix. Nonetheless not a huge
> amount of work and I agree with your assessment that this is an "easy" bug.

Yes. And perhaps a more abstract approach would make sense here. Extension:AddTab or something? An entire extension for a single tab (use-case) like this feels a bit yucky.

> A main benefit to an extension (over current situation) would probably be not
> having an extra ajax request to determine if the tab should be red or not on
> almost every page view.

Good point. The current JavaScript implementation of this feature is here: <https://en.wikinews.org/wiki/MediaWiki:Comments.js>.
Comment 3 Bawolff (Brian Wolff) 2012-11-17 00:21:00 UTC
Yes definitely. Additionally an extension would be much easier to deploy to other languages. It is a mess whenever some other lang wikinews wants the other tab.
Comment 4 Robin Pepermans (SPQRobin) 2012-11-17 18:05:35 UTC
A previous bug with an old patch is bug 13228 (with http://www.mediawiki.org/wiki/User:Svippong/AdditionalTabs - it uses a core solution with a general approach).

Maybe that or this bug should be marked as a duplicate of the other one?
Comment 5 MZMcBride 2012-11-17 20:23:17 UTC
Yes, I figured this was a duplicate. I couldn't find it. Thank you. Okay, here we go...

*** This bug has been marked as a duplicate of bug 13228 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links