Last modified: 2014-09-24 01:12:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15228, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13228 - Adding custom inter-namespace tabs
Adding custom inter-namespace tabs
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor with 5 votes (vote)
: ---
Assigned To: Pavel Selitskas [wizardist]
https://www.mediawiki.org/wiki/Reques...
:
: 42214 (view as bug list)
Depends on: 45666 52877
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-02 21:30 UTC by Conrad Irwin
Modified: 2014-09-24 01:12 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A hard patch (2.32 KB, patch)
2009-10-16 20:48 UTC, Svip
Details

Description Conrad Irwin 2008-03-02 21:30:06 UTC
It would be very useful, for things such as the Opinions: namespace on WikiNews and the Citations: namespace on Wiktionary to have the ability to add new tabs to the skin for every page in a namespace, either before or after the Talk: tab. They should work in the same way as that, but go to other namespaces. This would then lead to one Talk: page common across the namespaces that are linked up in this way.
Comment 1 Svip 2009-10-16 20:48:54 UTC
Created attachment 6677 [details]
A hard patch

Here is an early copy of a patch.  It may need add the variable it uses in the GlobalSettings.php file.  But that is another decision area.

There is a guide on how to use it here:

http://www.mediawiki.org/wiki/User:Svippong/AdditionalTabs
Comment 2 Daniel Friesen 2011-02-10 04:55:19 UTC
Currently this kind of thing can be done by using the SkinTemplateNavigation hook to modify the 'namespaces'. (For backwards compat you can add something to SkinTemplateTabs too, it's 1.18 when SkinTemplateNavigation starts to apply to all SkinTemplateSkins)
Comment 3 p858snake 2011-04-30 00:09:53 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 4 Sumana Harihareswara 2011-11-10 06:49:19 UTC
+need-review, inferring that svip wants feedback on the patch's approach
Comment 5 Sumana Harihareswara 2012-10-12 01:12:58 UTC
Robin, could you give svip some feedback?
Comment 6 Robin Pepermans (SPQRobin) 2012-11-17 18:08:15 UTC
The patch is quite old and would probably need to be adapted to current MediaWiki.

But there's also a new bug about the same issue, see bug 42214.
Comment 7 MZMcBride 2012-11-17 20:23:17 UTC
*** Bug 42214 has been marked as a duplicate of this bug. ***
Comment 8 MZMcBride 2012-11-17 20:35:00 UTC
(In reply to comment #7)
> *** Bug 42214 has been marked as a duplicate of this bug. ***

Okay, what this needs is a plan of action going forward. I've started an RFC here: <https://www.mediawiki.org/wiki/Requests_for_comment/Custom_inter-namespace_tabs>.

I'm removing "patch-need-review" and adding "easy". This bug is pretty easy to resolve, it just has a few unanswered implementation questions. This is why it needs an RFC to hammer things out properly.
Comment 9 Pavel Selitskas [wizardist] 2012-12-07 22:36:32 UTC
Please review: https://gerrit.wikimedia.org/r/#/c/37569/
Comment 10 Svip 2012-12-07 22:56:36 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > *** Bug 42214 has been marked as a duplicate of this bug. ***
> 
> Okay, what this needs is a plan of action going forward. I've started an RFC
> here:
> <https://www.mediawiki.org/wiki/Requests_for_comment/Custom_inter-
> namespace_tabs>.
> 
> I'm removing "patch-need-review" and adding "easy". This bug is pretty easy
> to
> resolve, it just has a few unanswered implementation questions. This is why
> it
> needs an RFC to hammer things out properly.

I decided to comment on your RFC.  I hope I am doing it right!
Comment 11 Pavel Selitskas [wizardist] 2013-01-03 19:37:50 UTC
I've submitted a patch into Gerrit about a month ago, and nobody reviewed it.

Is there anybody out there? https://gerrit.wikimedia.org/r/#/c/37569/
Comment 12 Pavel Selitskas [wizardist] 2013-01-10 01:24:47 UTC
The second take on this: https://www.mediawiki.org/wiki/Extension:NamespaceRelations

Needs one tiny fix to be merged into core to support queries (like editintro in Wikinews): https://gerrit.wikimedia.org/r/#/c/43118/. Request for new repo is pending.
Comment 13 Bartosz Dziewoński 2013-08-06 21:53:21 UTC
What's the status of this? Appropriate patches are merged, is there anything else left to do here?
Comment 14 Andre Klapper 2013-08-14 12:42:04 UTC
(In reply to comment #13)
> What's the status of this? Appropriate patches are merged, is there anything
> else left to do here?

No answer - assuming everything is fine.
Comment 15 Pavel Selitskas [wizardist] 2013-08-14 12:47:31 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > What's the status of this? Appropriate patches are merged, is there anything
> > else left to do here?
> 
> No answer - assuming everything is fine.

Sorry, I think it should be set FIXED if deployed.

The NamespaceRelations has a huge flow: if a page is moved, the page in a tertiary namespace is not moved. I believe the extension should not be deployed until I/anyone issues a patch that introduces this feature.

As from what I have seen in MovePage (correct me if I misspelled it), it's a mess of code and needs a lot of love. I'll be looking into it soon to have the feature described above implemented.
Comment 16 Andre Klapper 2013-08-14 13:05:47 UTC
(In reply to comment #15)
> Sorry, I think it should be set FIXED if deployed.

FIXED refers to merged into the codebase in Bugzilla. Deployment schedule can be found at https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap
Comment 17 MZMcBride 2013-08-15 01:01:18 UTC
(In reply to comment #16)
> (In reply to comment #15)
>> Sorry, I think it should be set FIXED if deployed.
> 
> FIXED refers to merged into the codebase in Bugzilla.

It seems particularly unwise to argue with the person who's been actively working on this bug and to whom the bug is currently assigned as to whether the bug is fixed or not.

This bug probably needs a few more dependencies (to cover, for example, the page move issue mentioned in comment 15). wizardist: if you could file any dependent bugs, that would be great.

> Deployment schedule can be found at
> https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap

Please do not link to irrelevant pages. There's nothing on that page that has anything to do with this bug. This feature is being implemented in an extension, not in MediaWiki core, and this extension has not yet been installed on Wikimedia wikis. The MediaWiki 1.22 roadmap, interesting as it is, currently has no bearing here.
Comment 18 Andre Klapper 2013-08-15 09:01:09 UTC
(In reply to comment #17)
> (In reply to comment #16)
> > (In reply to comment #15)
> >> Sorry, I think it should be set FIXED if deployed.
> > 
> > FIXED refers to merged into the codebase in Bugzilla.
> 
> It seems particularly unwise to argue with the person who's been actively
> working on this bug and to whom the bug is currently assigned as to whether
> the bug is fixed or not.

If there is still codework to do that has not been done yet (and that seems to be the case as per latest comments), this bug report should indeed remain open.
(If all required patches had been *merged* into the code repository but not *deployed* yet on Wikimedia servers, this bug report should be RESOLVED FIXED.)

> This bug probably needs a few more dependencies (to cover, for example, the
> page move issue mentioned in comment 15). wizardist: if you could file any
> dependent bugs, that would be great.

Yeah, that would definitely make it easier to see where we're at. :) 

Sorry for the confusion created here.
Comment 19 Bartosz Dziewoński 2013-10-16 13:28:33 UTC
Removing the 'easy' keyword. Extension is apparently written and awaiting code review, which is definitely not 'easy'.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links