Last modified: 2010-06-15 13:02:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1061 - CSS-added icons next to links display through the text and makes it unreadable in RTL
CSS-added icons next to links display through the text and makes it unreadabl...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 1060 3956 16502 (view as bug list)
Depends on:
Blocks: rtl css
  Show dependency treegraph
 
Reported: 2004-12-10 16:04 UTC by Gerard Meijsssen
Modified: 2010-06-15 13:02 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of problem from Firefox 1.0 (4.35 KB, image/png)
2005-01-03 02:28 UTC, Zigger
Details
proposed patch (6.01 KB, patch)
2009-02-01 19:44 UTC, Ahmad Sherif
Details
Patch for Opera9 (367 bytes, patch)
2009-02-21 20:23 UTC, Ahmad Sherif
Details
Replaces spaces with tabs (4.01 KB, patch)
2009-02-21 21:03 UTC, Ahmad Sherif
Details

Description Gerard Meijsssen 2004-12-10 16:04:44 UTC
When a soundfile is used that resides in commons in a Farsi, Arabic, Hebrew etc
the figure that indicates that it is an "external" resource is displayed within
the text itself and makes it unreadable. 

http://fa.wikibooks.org/wiki/FarsiLes7

As the file is within Commons there should not be this figure in the first
place; Commons is internal to the projects. It also does not display in IE so
why bother with this nuisance thingie ??

Thanks,
   GerardM
Comment 1 Brion Vibber 2004-12-10 21:51:45 UTC
Looks fine in Safari 1.2.4. Could you specify exactly which browsers (and versions) on which operating 
systems (and verisons) you've tested? (Presumably IE is not affected if you say it doesn't even display the 
image.) Can you confirm whether it's only media links with Farsi names, or also external links in general?

Consider filing a separate bug for the presence of the icon.
Comment 2 Rowan Collins [IMSoP] 2004-12-11 00:05:45 UTC
I can confirm that the external link icon appears over the text in the given
page in both Mozilla 1.7b and Firefox 0.10.1 under Windows 2000. And it does
indeed not appear at all under IE 5.0.
Comment 3 J. Noel Chiappa 2004-12-11 03:20:33 UTC
*** Bug 1060 has been marked as a duplicate of this bug. ***
Comment 4 Zigger 2005-01-03 02:27:02 UTC
More browser reports with monobook (under Windows 2000):
- Firefox 1.0 displays the problem
- IE 6.0 does not display the link icon
Comment 5 Zigger 2005-01-03 02:28:06 UTC
Created attachment 193 [details]
Screenshot of problem from Firefox 1.0
Comment 6 Lars Aronsson 2005-04-01 04:38:49 UTC
I'm using the monobook skin for Wikipedia and have an ancient Mozilla 1.6
browser, where I see this problem. I tried to understand how the "arrow" works,
and it seems to be related to the part of the CSS file /skins/monobook/main.css
that says:

#bodyContent a[href ^="http://"],
#bodyContent a[href ^="gopher://"] {
    background: url(external.png) center right no-repeat;
    padding-right: 13px;
}

and that perhaps the "right" should be "left" if this is Hebrew, Arabic, or
Farsi. And the "external.png" should then also be available in a version
pointing to the nortwest rather than northeast.

Perhaps the quickest fix is to replace external.png with a blank image on
he.wikipedia.org and ar.wikipedia.org.

I don't know, I'm just guessing.
Comment 7 Antoine "hashar" Musso (WMF) 2005-06-27 14:53:25 UTC
This is a RTL issue so.
Comment 8 Gabriel Wicke 2006-03-22 10:01:45 UTC
This is fixed, the rule above is only referencing a.external and gopher now.
Comment 9 lɛʁi לערי ריינהארט 2006-03-22 23:02:17 UTC
REOPENing as requested by Gabriel a while ago on IRC

The "Press call" link at
http://wikimediafoundation.org/wiki/%D7%AA%D7%A8%D7%95%D7%9E%D7%94_%D7%9C%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94
is still rendering wrong / overlapping with Hebrew text.

[[wikimedia:תרומה לויקיפדיה]]

best regards reinhardt [[user:gangleri]]
Comment 10 Gabriel Wicke 2006-03-24 08:56:55 UTC
This is fixed in RTL wikis, but not in RTL sections within LTR wikis. This will
need some markup help to make the different direction explicit, something along
the lines of

/* this can be used in the content area to switch off
special external link styling */
#bodyContent .plainlinks a,
#bodyContent span[dir="rtl"],
#bodyContent * span[dir="rtl"] {
	background: none !important;
	padding: 0 !important;
}

should work. There are other properties that might be desirable depending on the
language, so a match on lang would probably make even more sense (<span
lang="en-Gb" dir="ltr">), especially for Chinese and other scripts, but the
principle is the same.
Comment 11 Danny B. 2009-01-06 20:25:24 UTC
Changing the summary to more general, since all icons added via CSS on background behave the same.

Version -> unspecified since it is general problem.

----

Recent tests:
Firefox 2.0.0.18 - problems persist.
Opera 9.62 - problems persist.
Comment 12 Danny B. 2009-01-06 20:26:40 UTC
*** Bug 16502 has been marked as a duplicate of this bug. ***
Comment 13 Danny B. 2009-01-06 20:27:21 UTC
*** Bug 3956 has been marked as a duplicate of this bug. ***
Comment 14 Ahmad Sherif 2009-02-01 19:44:03 UTC
Created attachment 5767 [details]
proposed patch

I made a patch which may help displaying external links icons (and the new rss-feed icons). It was tested under 
* IE 6.0.2900.2180 - Windows XP SP2
* IE 7.0.5730.11 - Windows XP SP2
* Opera 7.54u2 - Windows XP SP2
* Opera 8.54 - Windows XP SP2
* Opera 9.63 - Ubuntu 8.10
* Firefox 3.0.5 - Ubuntu 8.10, Windows XP SP2
* Safari 3.2.1 - Windows XP SP2
* Konqueror 4.1.3 - Ubuntu 8.10
Because FF2 has a problem with padding when the document is rtl, so it has to be disabled. The patch supposes that there are two extra css files (FF2Fixes.css and Opera9Fixes.css) and one extra icon (external-rtl.png), the last one is a mirror image of external.png.

FF2Fixes.css:

.rtl .external, a.feedlink {
	padding: 0 !important;
	background: none !important;
}

Opera9Fixes.css:

.rtl #bodyContent a.external {
  background-image: url(external-rtl.png);
  padding-right: 0;
  padding-left: 13px;
}

.rtl a.feedlink {
  background-position: right;
  padding-right: 0;
  padding-left: 16px;
}
Comment 15 Huji 2009-02-01 20:01:08 UTC
(In reply to comment #14)

> Because FF2 has a problem with padding when the document is rtl, so it has to
> be disabled.

Isn't there any work around for that? (Like forcing a special "display" or so)
Comment 16 Ahmad Sherif 2009-02-01 20:20:34 UTC
(In reply to comment #15)
> 
> Isn't there any work around for that? (Like forcing a special "display" or so)
> 

I've tried using display and position properties before, but when the padding problem is solved, some other problems appears in the formatting of the text.
Comment 17 Ahmad Sherif 2009-02-20 21:14:54 UTC
The patch also has been tested under Google Chrome 1.0.154.48.
Comment 18 Mohamed Magdy 2009-02-21 15:08:19 UTC
I applied the patch in 47615.
Comment 19 Ahmad Sherif 2009-02-21 20:23:04 UTC
Created attachment 5841 [details]
Patch for Opera9

Comment #14 contains wrong css code for Opera 9. This patch fixes it.
Comment 20 Ahmad Sherif 2009-02-21 21:03:51 UTC
Created attachment 5842 [details]
Replaces spaces with tabs

Since the first patch uses spaces instead of tabs, this patch uses tabs to keep up with the rest of the code. It also contains the previous fix of Opera 9.
Comment 21 Mohamed Magdy 2009-02-22 04:25:54 UTC
applied in revision 47648. not marked as fixed until it is OK by brion|tim.
Comment 22 Brad Jorsch 2009-04-05 23:19:36 UTC
r47615 leaves odd space to the left of interwiki links (on LTR languages) that have CSS-added icons, for example [[irc:irc.freenode.net]], as interwiki links do not contain the "external" class so the ".ltr #bodyContent a.external" correction does not apply.
Comment 23 Ahmad Sherif 2009-04-06 15:55:01 UTC
(In reply to comment #22)
> r47615 leaves odd space to the left of interwiki links (on LTR languages) that
> have CSS-added icons, for example [[irc:irc.freenode.net]], as interwiki links
> do not contain the "external" class so the ".ltr #bodyContent a.external"
> correction does not apply.
> 

This was reported previously in bug 18207 and there is a patch proposed there but no one reviewed/committed it.
Comment 24 Ahmad Sherif 2009-06-18 15:58:44 UTC
I believe it's fixed now.
Comment 25 Sia 2009-10-18 20:22:50 UTC
in mediawiki 1.15.1:
the mail_icon.gif by mailto:link  not displayed, only external-rtl.png instead!?
Comment 26 Derk-Jan Hartman 2010-06-15 13:02:24 UTC
This bug was reopened, but the reopening is not related to the problem and should probably have been filed as a separate bug. If you still experience this bug, please open a new ticket.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links