Last modified: 2006-12-22 02:36:45 UTC
see attached patch
Created attachment 2856 [details] the patch some minor cleanup of the code.
Created attachment 2861 [details] the patch with parserTest added the parsertest for anchorencode
Created attachment 2864 [details] updated urlFunctions added funtionallity that in my brain was logical, as the posibillity to build query string by concatenate all extra parameters, for example {{localurl:Foo|a=1|b=2|c=3}} to give index.php?title=Foo&bar=baz&baz&boo /~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3
(In reply to comment #3) > Created an attachment (id=2864) [edit] > updated urlFunctions > > added funtionallity that in my brain was logical, as the posibillity to build > query string by concatenate all extra parameters, for example > {{localurl:Foo|a=1|b=2|c=3}} to give > index.php?title=Foo&bar=baz&baz&boo > /~azatoth/srcwiki/index.php?title=Foo&a=1&b=2&c=3 ment only "index.php?title=Foo&a=1&b=2&c=3", manage to copy a row too much
Please don't add major new functions in a patch that's supposed to be a "minor cleanup" - the two MUST be kept separate for code review reasons. (Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on you...)
(In reply to comment #5) > Please don't add major new functions in a patch that's supposed to be a "minor > cleanup" - the two MUST be kept separate for code review reasons. > > (Word of advice: The phrase "in my brain, [it] was logical" ALWAYS backfires on > you...) oh, sorry, perhaps you are right, sorry for making you upset, I'll revert it
Would like this to be committed if possible, it's rather straightforward I think
Applied on r18484. Patience is a virtue.