Last modified: 2014-08-29 08:26:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10171, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 8171 - Pressing 'show changes' button shows intermediate changes to other sections as well
Pressing 'show changes' button shows intermediate changes to other sections a...
Status: NEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
Other All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 70163
  Show dependency treegraph
Reported: 2006-12-06 08:41 UTC by Thomas Zander
Modified: 2014-08-29 08:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Thomas Zander 2006-12-06 08:41:18 UTC
To reproduce;
take a page with multiple sections.
Change a section by pressing edit.

Another user changes another section while the first user has his browser window open. 
Going through the edit/save page sequence.

Pressing 'show changes' in the first users window will show the changes he made, but also 
the changes the second user committed in the mean time.

I expect my changes to be restricted to the section I am editing.
Comment 1 Phil Boswell 2006-12-06 08:50:35 UTC
This is expected behaviour: depending upon whether your changes conflict with the other 
editor's, you might or might not get an edit conflict. This is invaluable in certain 
circumstances, where for example you want to see if someone else has beaten you to a 
correction or a comment.

I'm tempted to close this as "invalid" but others might want to comment further...
Comment 2 Thomas Zander 2006-12-06 09:08:25 UTC
I would expect the behavior if I were editing the whole document; not if both edits 
were about _different_ sections.
That, to me, falls in the same category as editing two different pages and I expect to 
not see diffs of other pages since I started either.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-12-07 03:00:28 UTC
At the very least it needs to note that some changes aren't yours, lest you
suspect yourself of insanity.
Comment 4 Thomas Zander 2006-12-07 09:50:00 UTC
hihi, yeah. Pesonally, I was more concerned I would end up 
reverting someone elses changes were I to press save.
Comment 5 Matthew Flaschen 2008-08-09 07:59:18 UTC
It is not expected behavior.  Say the page looks like:


Assume I click edit section for A.  Someone immediately after (while I still have the edit window open) changes section B, then saves.  The page is now:

If I now change foo to goo and click Show changes, there is no edit conflict (this is one of the main purposes of editing sections).  The only change that should show is foo to goo.

The way to calculate this is simple.  The left side of the diff is the last wikitext for the whole page.  The right side is formed by taking the left side, then substituting my new section A for the old section A.  Only if there is *no* section A on the left should it resort to the current behavior.
Comment 6 Matthew Flaschen 2008-08-09 08:06:08 UTC
If there is no section A in the last saved version, it currently shows your section A being added.  However, an edit conflict is forced when you save your changes (which is correct).
Comment 7 Trevor Johnson 2011-07-06 08:34:24 UTC
RE: I'm tempted to close this as "invalid" but others might want to comment further...

It certainly confused me! I inserted some {{clear}} tags in a Wikipedia article by editing the whole document
(typo subsequently corrected)

but was confused by intervening edits to the 'Titles and styles' section
which I wasn't editing.

Pending further comments here, I'll search to see whether this is documented in the relevant section(s) in Wikipedia's guidance.

Comment 8 Joe Decker 2011-07-08 02:11:39 UTC
Just a comment, we got an OTRS comment on either the same or a very related matter, essentially, start editing some sections in parallel, save changes on a couple, then do a show changes in the remaining window--you can get effects where "show changes" appears to show you'll be reverting the changes to other sections.

I can produce a full test case if anyone is interested, but it looks to be part and parcel of this whole discussion.

Note You need to log in before you can comment on or make changes to this bug.