Last modified: 2006-12-04 20:09:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8141 - Cleanup of Parser::doTableStuff
Cleanup of Parser::doTableStuff
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2006-12-03 23:10 UTC by Carl Fürstenberg
Modified: 2006-12-04 20:09 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

patch cleaning up the code (9.08 KB, patch)
2006-12-03 23:11 UTC, Carl Fürstenberg
patch cleaning up the code (9.82 KB, patch)
2006-12-04 18:01 UTC, Carl Fürstenberg
patch cleaning up the code (9.85 KB, patch)
2006-12-04 18:09 UTC, Carl Fürstenberg

Description Carl Fürstenberg 2006-12-03 23:10:41 UTC
Reading that code might give some less "hardcore" people an headake. Following
patch is my attempt to cleanup the code.
Comment 1 Carl Fürstenberg 2006-12-03 23:11:32 UTC
Created attachment 2820 [details]
patch cleaning up the code

I have checked with parsertest, and it pass.
Comment 2 Carl Fürstenberg 2006-12-04 18:01:35 UTC
Created attachment 2821 [details]
patch cleaning up the code

Fixing the possible undefined index on row 797, fixed some comments. Also I
ensure that there are enough whitespaces to make everyone happy.
Comment 3 Carl Fürstenberg 2006-12-04 18:09:35 UTC
Created attachment 2822 [details]
patch cleaning up the code

removed the unnecissary variable $tmp_line as it is unnecissary and don't add
to the logic of the code, moved up the attribute code instead in it's place and
use the variable $line again instead in the rest of the block, which for me
makes more sense.
Comment 4 Leon Weber 2006-12-04 20:09:53 UTC
Applied in r18160.

Note You need to log in before you can comment on or make changes to this bug.