Last modified: 2006-11-18 18:46:18 UTC
I was puzzling over this segment of code for some time: if ( $code != 'en' ) { $fallback = 'en'; } else { $fallback = false; } ...wondering: "Hmm... doesn't that mean that English is the only possible fallback language?" After all, looking at the immediately following code, $fallback was not every set to a different value. Then, it hit me: "Of course! This include did it: require( $filename ); $fallback was a variable in the actual file, so 'en' would get nicely overwritten if necessary. So... perhaps a short comment would help elucidate the meaning of that block for anyone else who might have gotten confused. Patch coming.
Created attachment 2733 [details] Adds a short comment explaining the bheavior Adds the comment "Default fallback, may be overridden when we include the messages file" to the code in question.
Created attachment 2734 [details] Fixes it without nuking tabs Whoops, murdered a few tabs. New and improved patch.
Added in r17791.