Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75591, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 73591 - VisualEditor: Decide whether this.active should be in mw.Target or mw.ViewPageTarget

Summary:	VisualEditor: Decide whether this.active should be in mw.Target or mw.ViewPag...

Status: ASSIGNED Product: VisualEditor Classification: Unclassified Component: Technical Debt (Other open bugs) Version: unspecified Hardware: All All Importance: Normal enhancement Target Milestone: --- Assigned To: Editing team bugs – take if you're interested! URL: Whiteboard: Keywords: Depends on: Blocks: 73593   Show dependency tree / graph		Reported: 2014-11-19 02:43 UTC by Roan Kattouw Modified: 2014-11-19 02:57 UTC (History) CC List: 4 users (show) elitre82 etonkovidova jforrester ryasmeen See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-11-19 02:43:48 UTC Right now ViewPageTarget defines this.active, but it's set to true by mw.Target. This is horrible. The obvious fix is to push the setting to true down to ViewPageTarget, but we should consider whether the Target class itself should have some sort of active state.