Last modified: 2014-11-18 21:44:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75561, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73561 - Page.categories withSortKey ignored
Page.categories withSortKey ignored
Status: PATCH_TO_REVIEW
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Unprioritized major
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: pwb20
  Show dependency tree / graph
 
Reported: 2014-11-18 16:31 UTC by John Mark Vandenberg
Modified: 2014-11-18 21:44 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-11-18 16:31:47 UTC 
Site.pagecategories in core does not accept the parameter withSortKey which was present in compat, and no alternative implementation is available.

Page.categories in core even exposes a withSortKey parameter, which is passes to Site.pagecategories, only for it to be ignored.
Comment 1 Gerrit Notification Bot 2014-11-18 16:32:15 UTC 
Change 148619 had a related patch set uploaded by John Vandenberg:
Add param "from_raw_text", "props" to Page.categories()

https://gerrit.wikimedia.org/r/148619
Comment 2 Gerrit Notification Bot 2014-11-18 16:49:57 UTC 
Change 174143 had a related patch set uploaded by John Vandenberg:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143
Comment 3 John Mark Vandenberg 2014-11-18 17:08:31 UTC 
(In reply to John Mark Vandenberg from comment #0)
> Page.categories in core even exposes a withSortKey parameter

fwiw ... withSortKey parameter isnt in the compat method arguments.  However the sort key is populated by getCategoryLinks , which is called by Page.categories if the site doesnt have an API.
Comment 4 Gerrit Notification Bot 2014-11-18 18:09:32 UTC 
Change 174143 merged by jenkins-bot:
Page.categories parameter withSortKey ignored

https://gerrit.wikimedia.org/r/174143
Comment 5 John Mark Vandenberg 2014-11-18 21:44:40 UTC 
Now to work on merging the real fix...

https://gerrit.wikimedia.org/r/148619
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links