Last modified: 2014-11-20 19:05:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75531, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73531 - ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test
ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-ma...
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.25-git
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm, upstream
Depends on:
Blocks: 73175 73521
  Show dependency treegraph
 
Reported: 2014-11-17 22:42 UTC by Tim Landscheidt
Modified: 2014-11-20 19:05 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Landscheidt 2014-11-17 22:42:11 UTC
https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-master/2653/testReport/:

| ApiFormatWddxTest::testValidSyntax
| Failed asserting that null is of type "array".

| /mnt/jenkins-workspace/workspace/mediawiki-core-regression-hhvm-master/src/tests/phpunit/includes/api/format/ApiFormatWddxTest.php:17
| /mnt/jenkins-workspace/workspace/mediawiki-core-regression-hhvm-master/src/tests/phpunit/MediaWikiTestCase.php:141
Comment 1 Antoine "hashar" Musso (WMF) 2014-11-18 08:49:10 UTC
The console log shows:

 Entity: line 1: parser error : xmlParseEntityRef: no name
 ring>/^([a-z]+)(.*)$/sD</string></var><var name='legaltitlechars'><string> %!"$&


And points to the ampersand at the end of the line.
Comment 2 Tim Landscheidt 2014-11-19 01:36:58 UTC
This is an error in hhvm's WDDX serialization.  A test script:

| <?php
| $s = wddx_serialize_value("Test for &");
| var_dump($s);
| $d = wddx_deserialize($s);
| var_dump($d);

works on my PHP 5.5.18:

| string(92) "<wddxPacket version='1.0'><header/><data><string>Test for &amp;</string></data></wddxPacket>"
| string(10) "Test for &"

but fails on HipHop VM 3.3.1:

| string(88) "<wddxPacket version='1.0'><header/><data><string>Test for &</string></data></wddxPacket>"
| Entity: line 1: parser error : xmlParseEntityRef: no name
| <wddxPacket version='1.0'><header/><data><string>Test for &</string></data></wdd
|                                                            ^
| NULL

I filed https://github.com/facebook/hhvm/issues/4283 upstream.
Comment 3 Antoine "hashar" Musso (WMF) 2014-11-19 08:44:26 UTC
CCing Tim Starling since he did some commit to wddx ( https://github.com/facebook/hhvm/commit/46f5476b0c52b8b7564b40a315d92b294607257a )
Comment 4 Antoine "hashar" Musso (WMF) 2014-11-19 21:10:21 UTC
Upstream has a fix internally :]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links