Last modified: 2014-11-14 17:57:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75366, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73366 - New comments are not generating mention notifications
New comments are not generating mention notifications
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Erik Bernhardson
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-13 13:53 UTC by Helder
Modified: 2014-11-14 17:57 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2014-11-13 13:53:54 UTC 
The edit
https://pt.wikipedia.org/w/index.php?diff=40601300
added a comment in the format
:::{{Ping|MyUserName}} Comment. <HisSignature> 13h35min de 13 de novembro de 2014 (UTC)
to a talk page but it didn't generate a notification.
Comment 1 Helder 2014-11-13 14:38:22 UTC 
The ping works if the signature contains "User"
https://pt.wikipedia.org/w/index.php?diff=40601702
or "Usuário"
https://pt.wikipedia.org/w/index.php?diff=40601695
but doesn't work anymore if it contains "Usuário(a)"
https://pt.wikipedia.org/w/index.php?diff=40601676
Comment 2 Erik Bernhardson 2014-11-13 18:25:24 UTC 
Verified that the Title class does not detect Usuário(a) as NS_USER:

    ebernhardson@tin:~$ mwscript eval.php --wiki=ptwiki                                                            
    > $t = Title::newFromText( 'Usurio(a):Reverta-me' );
    > echo $t->getNamespace()
    0

Not sure how to fix yet, looking into it
Comment 3 Erik Bernhardson 2014-11-13 19:10:38 UTC 
Actually eval.php ate the non-ascii chracters.  The title class in ptwiki correctly detects this as NS_USER.
Comment 4 Quiddity 2014-11-13 19:12:16 UTC 
On trello at https://trello.com/c/vLKd47sL/
Comment 5 Gerrit Notification Bot 2014-11-13 19:52:46 UTC 
Change 173077 had a related patch set uploaded by EBernhardson:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173077
Comment 6 Gerrit Notification Bot 2014-11-13 21:51:18 UTC 
Change 173077 merged by jenkins-bot:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173077
Comment 7 Gerrit Notification Bot 2014-11-13 22:00:51 UTC 
Change 173116 had a related patch set uploaded by EBernhardson:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173116
Comment 8 Gerrit Notification Bot 2014-11-13 22:03:02 UTC 
Change 173118 had a related patch set uploaded by EBernhardson:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173118
Comment 9 Gerrit Notification Bot 2014-11-13 23:56:28 UTC 
Change 173118 merged by jenkins-bot:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173118
Comment 10 Gerrit Notification Bot 2014-11-13 23:56:41 UTC 
Change 173116 merged by jenkins-bot:
Bug: parenthesis are allowed in namespaces

https://gerrit.wikimedia.org/r/173116
Comment 11 Erik Bernhardson 2014-11-14 00:20:10 UTC 
deployed fix to prod
Comment 12 Helder 2014-11-14 17:57:49 UTC 
Er... the user still can't notify me, but now due to bug 73426.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links