Last modified: 2014-11-03 20:52:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74909, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72909 - Login link redirect to default login (not GoogleLogin)
Login link redirect to default login (not GoogleLogin)
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
GoogleLogin (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Florian
:
Depends on: 72910
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-03 16:21 UTC by tim.schenk
Modified: 2014-11-03 20:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tim.schenk 2014-11-03 16:21:51 UTC
The link supplied by the mobile page redirects to :
http://wiki.firstconsulting.nl/Speciaal:Aanmelden <-- dutch 

This is the default login page and not the special GoogleLogin page. 
In my LocalSetting.php I have:
$wgGLReplaceMWLogin = true;

Is this a GoogleLogin bug, or a MobileFrontend bug?
Comment 1 Florian 2014-11-03 17:35:34 UTC
Actually it depends on MobileFrontend in a special way :) Both Extensions, MobileFrontend and GoogleLogin, will rewrite the handler for the Login class. GoogleLogin will do this only, if $wgGLReplaceMWLogin is set to true to prevent the vanilla LoginForm to appear.

MobileFrontend was created in an early version of MediaWiki and had to replace the LoginForm, too, to fit the needs of a mobile device (it will do this every time, the user is in mobile mode).

Now, the problem is, that the login page can be only one class and it wins the extension that has overwritten the key last.

So, in fact, the Extension which was loaded last will provide the login screen. That means for you, as a quick fix, that you can place the "require_once" line of GoogleLogin somewhere _after_ the MobileFrontend "require_once" line. This should solve the problem for now.

The best solution is, that MobileFrontend doesn't need to overwrite the login page anymore. Actually, the developer team is working on this and implemented such a feature in the alpha mode of MobileFrontend (I8f89bdaf3dc7fde104f199554b18486c30580910). It will take some time to solve this problem, but it isn't a real bug of GoogleLogin. I will create a tracking but for this in MobileFrontend :)

(I will set the status of this bug to assigned and take it anyway, but the work has to be done in MobileFrontend :))

P.S.: Thanks for the very detailed bug report! :)
Comment 2 tim.schenk 2014-11-03 20:36:34 UTC
Florian, thanks for your help.
Changing the order in which the extensions load solves my problem.

Thanks again for the fast reply!
Comment 3 Florian 2014-11-03 20:51:18 UTC
Thanks for confirm this :)

Added the info to the Extension page: [[Extension:GoogleLogin#MobileFrontend_.3C-.3E_GoogleLogin_conflict_.28only_with_.24wgGLReplaceMWLogin_.3D_true.21.29]]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links