Last modified: 2014-11-03 21:00:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74705, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72705 - OOUI PHP: Use a namespace for our classes
OOUI PHP: Use a namespace for our classes
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 72713
  Show dependency tree / graph
 
Reported: 2014-10-29 21:51 UTC by Bartosz Dziewoński
Modified: 2014-11-03 21:00 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-10-29 21:51:15 UTC 

    


      




        
          Comment 1
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-11-01 01:27:34 UTC
        
      





Change 170501 had a related patch set uploaded by Bartosz Dziewoński:
OOUI PHP: Use 'OOUI' namespace instead of 'OoUi' class name prefix

https://gerrit.wikimedia.org/r/170501

    


      




        
          Comment 2
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-11-03 20:59:42 UTC
        
      





Change 170501 merged by jenkins-bot:
OOUI PHP: Use 'OOUI' namespace instead of 'OoUi' class name prefix

https://gerrit.wikimedia.org/r/170501

    


      




        
          Comment 3
        

        
          Bartosz Dziewoński

        

        
        

        
          2014-11-03 20:59:55 UTC
        
      





There were some concerns raised on the patch that this usage doesn't quite match PHP best practices, but we'd need to do quite a bit of renaming to do that (also on the JS side to stay consistent).

I'm open to suggestions that don't require me to do massive semi-manual search-and-replaces on thousands of lines of code that uses JS OOUI already. :)

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		

		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links