Last modified: 2014-11-01 06:38:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74686, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72686 - BounceHandlerActions::handleFailingRecipient() SQL query


Summary:	BounceHandlerActions::handleFailingRecipient() SQL query

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	BounceHandler (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Tony Thomas

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	69019
	Show dependency tree / graph

Reported:	2014-10-29 17:26 UTC by Sam Reed (reedy)
Modified:	2014-11-01 06:38 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-10-29 17:26:39 UTC

array(
				'br_user'=> $originalEmail,
				'br_timestamp' >= $bounceValidPeriod
			),

'br_timestamp' >= $bounceValidPeriod

This will be evaluated as a bool. Needs to be something more like

'br_timestamp >= ' . $bounceValidPeriod


Also a missing space after 'br_user'

Comment 1 Chris Steipp 2014-10-30 00:27:06 UTC

(In reply to Sam Reed (reedy) from comment #0)
> array(
> 				'br_user'=> $originalEmail,
> 				'br_timestamp' >= $bounceValidPeriod
> 			),
> 
> 'br_timestamp' >= $bounceValidPeriod
> 
> This will be evaluated as a bool. Needs to be something more like
> 
> 'br_timestamp >= ' . $bounceValidPeriod

Just please quote $bounceValidPeriod if you're writing the sql yourself

Comment 2 Sam Reed (reedy) 2014-10-30 00:28:16 UTC

(In reply to Chris Steipp from comment #1)
> (In reply to Sam Reed (reedy) from comment #0)
> > array(
> > 				'br_user'=> $originalEmail,
> > 				'br_timestamp' >= $bounceValidPeriod
> > 			),
> > 
> > 'br_timestamp' >= $bounceValidPeriod
> > 
> > This will be evaluated as a bool. Needs to be something more like
> > 
> > 'br_timestamp >= ' . $bounceValidPeriod
> 
> Just please quote $bounceValidPeriod if you're writing the sql yourself

Aaron already did :)  https://gerrit.wikimedia.org/r/#/c/169760/

And broke the tests :D

Comment 3 Gerrit Notification Bot 2014-10-31 08:32:03 UTC

Change 170290 had a related patch set uploaded by 01tonythomas:
Fixed DB timestamp range query in BounceHandler extension

https://gerrit.wikimedia.org/r/170290

Comment 4 Gerrit Notification Bot 2014-10-31 14:38:11 UTC

Change 170290 merged by jenkins-bot:
Fixed DB timestamp range query in BounceHandler extension

https://gerrit.wikimedia.org/r/170290

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links