Last modified: 2014-10-30 19:59:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74684, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72684 - Inconsistent returns in BounceHandler


Summary:	Inconsistent returns in BounceHandler

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	BounceHandler (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Tony Thomas

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	69019
	Show dependency tree / graph

Reported:	2014-10-29 17:20 UTC by Sam Reed (reedy)
Modified:	2014-10-30 19:59 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-10-29 17:20:31 UTC

Only the else block returns anything.

Should self::generateVerp be prepended with a return? (though, I note that always returns true)

Comment 1 Sam Reed (reedy) 2014-10-29 17:29:45 UTC

(In reply to Sam Reed (reedy) from comment #0)
> Only the else block returns anything.
> 
> Should self::generateVerp be prepended with a return? (though, I note that
> always returns true)

That was for BounceHandlerHooks::onVERPAddressGenerate()




Also, ProcessBouncEmails::processEmail() doesn't return on all paths

Comment 2 Sam Reed (reedy) 2014-10-29 17:30:50 UTC

ProcessBounceEmails::getOriginalEmail() too

Comment 3 Gerrit Notification Bot 2014-10-30 18:43:26 UTC

Change 170112 had a related patch set uploaded by 01tonythomas:
Fix inconsistent returns in BounceHandler extension

https://gerrit.wikimedia.org/r/170112

Comment 4 Gerrit Notification Bot 2014-10-30 19:57:50 UTC

Change 170112 merged by jenkins-bot:
Fix inconsistent returns in BounceHandler extension

https://gerrit.wikimedia.org/r/170112

Comment 5 Tony Thomas 2014-10-30 19:59:53 UTC

Thanks Reedy for reporting those!

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links