Last modified: 2014-10-30 01:42:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74542, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72542 - OOUI PHP: No simple way to add HTML-escaped text to a Element
OOUI PHP: No simple way to add HTML-escaped text to a Element
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 72713
  Show dependency treegraph
 
Reported: 2014-10-26 23:21 UTC by Bartosz Dziewoński
Modified: 2014-10-30 01:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-10-26 23:21:37 UTC
There's no simple way to add HTML-escaped text to a Element. OoUiTag::appendContent() doesn't escape strings.

I say we should add a appendText() method and use it where applicable.
Comment 1 Bartosz Dziewoński 2014-10-27 00:01:45 UTC
We currently have some bugs where JS and PHP escape things differently because of this.
Comment 2 Gerrit Notification Bot 2014-10-27 19:12:41 UTC
Change 169106 had a related patch set uploaded by Bartosz Dziewoński:
OoUiTag: HTML-escape everything by default

https://gerrit.wikimedia.org/r/169106
Comment 3 Gerrit Notification Bot 2014-10-29 23:31:26 UTC
Change 169106 merged by jenkins-bot:
OoUiTag: HTML-escape everything by default

https://gerrit.wikimedia.org/r/169106

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links