Last modified: 2014-11-19 18:41:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74387, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72387 - "createaccount" action failure should return the name of the extension that caused it to fail.
"createaccount" action failure should return the name of the extension that c...
Status: NEW
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 72331 73616
  Show dependency treegraph
 
Reported: 2014-10-22 21:21 UTC by Dmitry Brant
Modified: 2014-11-19 18:41 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dmitry Brant 2014-10-22 21:21:56 UTC
In our Android app, we allow the user to create an account, and if the API rejects the account creation request, we would like to tell the user exactly why it was rejected.

When the createaccount action fails because of an extension, we get back a "code" of "createaccount-hook-aborted", which is not specific enough for us to understand what the exact error is.

We do see the "info" text, which is HTML, but we don't want to display it as-is inside the app, for various reasons (e.g. localization).

Ideally the API should tell us which extension was responsible for rejecting the request, so that we may decide how to present the corresponding error to the user.
Comment 1 Kunal Mehta (Legoktm) 2014-10-23 05:58:06 UTC
I think AntiSpoof just needs to use the API specific hooks (like was done to ConfirmEdit in Id628defaeab2bf5979ca8f4284d14fc42d9c3e46).
Comment 2 Brad Jorsch 2014-10-23 16:22:55 UTC
The API-specific hooks aren't actually necessary for this. AddNewAccountApiForm is really intended for mapping from parameters named in API style (such as "captchaid" and "captchaword") to form style (such as "wpCaptchaId" and "wpCaptchaWord"), while AddNewAccountApiResult is for adjusting a non-fatal outcome.

AntiSpoof needs to update its AbortNewAccount hook function to use the $abortStatus parameter added to that hook in 1.23, if it wants to avoid a generic 'createaccount-hook-aborted' message.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links