Last modified: 2014-11-11 10:04:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74184, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72184 - fix the qunit tests for wikidata: mwext-Wikibase-qunit
fix the qunit tests for wikidata: mwext-Wikibase-qunit
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
u=dev c=qa p=0
:
Depends on: 72063
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-17 14:37 UTC by Jan Zerebecki
Modified: 2014-11-11 10:04 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jan Zerebecki 2014-10-17 14:37:53 UTC
Fix the qunit tests for wikidata: mwext-Wikibase-qunit and after that make them voting.
Comment 1 Jan Zerebecki 2014-10-30 15:27:37 UTC
It seems /srv/localhost/qunit/ is missing on the instances. That is created by puppet class contint::qunit_localhost which is not applied on that host. It is only applied in role::ci::slave and not anything that is applied on labs (like role::ci::slave::labs). So the jenkins slave selector in that jobs config might need adjusting (if there is a qunit specific one, see other qunit jobs) and contint::qunit_localhost should also be applied on (some?) jenkins labs instances.
Comment 2 Gerrit Notification Bot 2014-11-06 13:26:43 UTC
Change 171535 had a related patch set uploaded by Adrian Lang:
Add qunit localhost setup to role::ci::slave::labs

https://gerrit.wikimedia.org/r/171535
Comment 3 Krinkle 2014-11-06 15:37:02 UTC
Don't do that. This job should not be running in labs to begin with. Installing mediawiki and serving it from Apache for a qunit testing, grunt, and correct node and phantomjs version has not been done yet for labs.


See bug 72063 for that (which I'm already working on).
Comment 4 Jan Zerebecki 2014-11-06 17:12:03 UTC
If composer now works on production jenkins slave, droping the wikidata jenkins slave selector and adding the one for qunit might work.
Comment 5 Jan Zerebecki 2014-11-06 17:19:14 UTC
OK contint::slave-scripts which is what installs composer on labs isn't supposed to run in production. That should not be changed, so no way for us to run the qunit tests unless they run in labs.
Comment 6 Krinkle 2014-11-06 21:07:34 UTC
(In reply to Jan Zerebecki from comment #5)
> OK contint::slave-scripts which is what installs composer on labs isn't
> supposed to run in production. That should not be changed, so no way for us
> to run the qunit tests unless they run in labs.

For mediawiki-core this is solved by using mediawiki-vendor, just like we do in production. How does wikidata run in production without composer?
Comment 7 Jan Zerebecki 2014-11-07 11:08:35 UTC
For extensions/Wikibase.git composer is one of the things run during build time, the whole build result is commited to extensions/Wikidata.git which is what gets deployed. Independent of that there are many dependencies that are updated often so that integration runs without running composer are much less useful.
Comment 8 Gerrit Notification Bot 2014-11-11 10:04:51 UTC
Change 171535 abandoned by Adrian Lang:
Add qunit localhost setup to role::ci::slave::labs

https://gerrit.wikimedia.org/r/171535

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links