Last modified: 2014-10-12 14:37:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73955, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71955 - rename fallback-svg to fallback-image


Summary:	rename fallback-svg to fallback-image

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Math (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	65341
	Show dependency tree / graph

Reported:	2014-10-11 14:48 UTC by physikerwelt
Modified:	2014-10-12 14:37 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description physikerwelt 2014-10-11 14:48:38 UTC

since it's now decided on client side if it's an svg or an png image
svg might be confusing if it's replaced by png

Comment 1 Frédéric Wang 2014-10-11 15:03:04 UTC

That's what I initially try in patch 1 of https://gerrit.wikimedia.org/r/#/c/166084/, but I realized that PNG and SVG have slightly different style (for vertical alignment in inline mode and horizontal centering in display mode) so I was not 100% sure we could merge them.

Comment 2 Frédéric Wang 2014-10-11 19:28:23 UTC

As discussed on IRC, after https://gerrit.wikimedia.org/r/#/c/166212/ the only difference will be in the vertical alignment which is done in MathMathML.php for the SVG.

For the PNG, we could add "vertical-align: center" in MathTexvc.php and in ext.math.js. Then the class name could be merged.

Comment 3 Gerrit Notification Bot 2014-10-12 09:33:28 UTC

Change 166280 had a related patch set uploaded by Frédéric Wang:
Rename fallback-svg and fallback-png to fallback-image

https://gerrit.wikimedia.org/r/166280

Comment 4 Gerrit Notification Bot 2014-10-12 12:14:39 UTC

Change 166280 merged by Physikerwelt:
Rename fallback-svg and fallback-png to fallback-image

https://gerrit.wikimedia.org/r/166280

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links