Last modified: 2014-11-06 16:35:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73864, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71864 - Travis builds not loading flickrripper due to missing ImageTk
Travis builds not loading flickrripper due to missing ImageTk
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
tests (Other open bugs)
core-(2.0)
All All
: Low normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: pwb_script_tests
  Show dependency treegraph
 
Reported: 2014-10-09 05:55 UTC by John Mark Vandenberg
Modified: 2014-11-06 16:35 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2014-10-09 05:55:36 UTC
As mentioned on bug 71454 comment 2 , current travis builds are not loading flickrripper as script_tests cant import dependency ImageTk

https://travis-ci.org/wikimedia/pywikibot-core/jobs/37419168

"flickrripper depends on ImageTk, which isnt available:
No module named ImageTk"
Comment 1 Gerrit Notification Bot 2014-11-03 01:13:37 UTC
Change 170647 had a related patch set uploaded by John Vandenberg:
Script test checks: import ImageTk from PIL

https://gerrit.wikimedia.org/r/170647
Comment 2 John Mark Vandenberg 2014-11-03 01:20:56 UTC
py2.6, py2.7 and py3 builds all have an error when installing Pillow on Travis
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39756966
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39760334
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39756970

which was done here:
https://gerrit.wikimedia.org/r/#/c/159207/

The builds all report the following in the Pillow install routine:
--- TKINTER support available

Yet script_tests cant load the module ImageTk.  It needs to be loaded as 'from PIL import ImageTk' , but 'import PIL.ImageTk' appears to work for a few versions of Pillow that I have tried.
Comment 3 Gerrit Notification Bot 2014-11-04 01:51:00 UTC
Change 170647 merged by jenkins-bot:
Script test checks: import ImageTk from PIL

https://gerrit.wikimedia.org/r/170647
Comment 4 John Mark Vandenberg 2014-11-05 03:02:13 UTC
After a bit of playing with a brand new install of Python, I can reproduce this.

setup.py test is installing flickrapi into the local directory, and it can be imported within the setup.py environment, ..

/home/travis/build/wikimedia/pywikibot-core/flickrapi-2.0_beta0-py3.3.egg

But, when flickrripper is invoked via pwb.py, flickrapi can not be found.
Comment 5 Gerrit Notification Bot 2014-11-05 03:38:50 UTC
Change 171194 had a related patch set uploaded by John Vandenberg:
Export sys.path to pwb scripts

https://gerrit.wikimedia.org/r/171194
Comment 6 Gerrit Notification Bot 2014-11-05 13:16:17 UTC
Change 171194 merged by jenkins-bot:
Export sys.path to pwb scripts

https://gerrit.wikimedia.org/r/171194

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links