Last modified: 2014-10-08 21:32:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73782, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71782 - ImageMetrics QUnit fails for no reason


Summary:	ImageMetrics QUnit fails for no reason

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-08 08:41 UTC by Gilles Dubuc
Modified:	2014-10-08 21:32 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gilles Dubuc 2014-10-08 08:41:22 UTC

Empty change: https://gerrit.wikimedia.org/r/#/c/165448/

Systematic cryptic failure: https://integration.wikimedia.org/ci/job/mwext-ImageMetrics-qunit/6/consoleFull

Can't reproduce locally, those tests work just fine.

I think that jenkins qunit actually always failed for that extension, ever since it was turned on:

https://gerrit.wikimedia.org/r/#/c/164427/

Comment 1 Gilles Dubuc 2014-10-08 08:48:53 UTC

With all the qunit tests of that extension manually commented out, it still fails the same way.

Comment 2 Gerrit Notification Bot 2014-10-08 09:04:23 UTC

Change 165455 had a related patch set uploaded by Hashar:
Disable voting for mwext-ImageMetrics-qunit

https://gerrit.wikimedia.org/r/165455

Comment 3 Gerrit Notification Bot 2014-10-08 09:05:20 UTC

Change 165455 merged by jenkins-bot:
Disable voting for mwext-ImageMetrics-qunit

https://gerrit.wikimedia.org/r/165455

Comment 4 Gerrit Notification Bot 2014-10-08 09:18:18 UTC

Change 165456 had a related patch set uploaded by Hashar:
ImageMetrics depends on EventLogging

https://gerrit.wikimedia.org/r/165456

Comment 5 Gerrit Notification Bot 2014-10-08 09:21:30 UTC

Change 165457 had a related patch set uploaded by Hashar:
Revert "Disable voting for mwext-ImageMetrics-qunit"

https://gerrit.wikimedia.org/r/165457

Comment 6 Gerrit Notification Bot 2014-10-08 09:23:19 UTC

Change 165456 merged by jenkins-bot:
ImageMetrics depends on EventLogging

https://gerrit.wikimedia.org/r/165456

Comment 7 Gerrit Notification Bot 2014-10-08 09:26:08 UTC

Change 165457 merged by jenkins-bot:
Revert "Disable voting for mwext-ImageMetrics-qunit"

https://gerrit.wikimedia.org/r/165457

Comment 8 Antoine "hashar" Musso (WMF) 2014-10-08 09:29:33 UTC

Turns out the qunit test for ImageMetrics hit some EventLogging web service. Since EventLogging was not installed as a dependency that caused the nasty error.

The PHPUnit test suite properly mock EventLogging (though it now has the extension cloned as well).

The qunit part might need to mock the EventLogging service as well but I am not sure whether we have any code for that already.  Might not be worth the effort.


Current status:

* Test is voting and passing now
* EventLogging is fetched as a dependency for both PHPUnit and Qunit jobs.

Comment 9 Tisza Gergő 2014-10-08 09:38:01 UTC

We mock qunit manually in the tests but the way Special:JavaScriptTest works is that it loads the live code and then loads the test code, and the live code has an onload handler doing actual logging.

We could add a condition to check the page name and ignore Special:JavaScriptTest, I guess.

Comment 10 Tisza Gergő 2014-10-08 21:32:52 UTC

Or we can just be lazy and ignore that. The tests work, there should be no practical disadvantage of the current setup.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links