Last modified: 2014-11-12 11:37:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73743, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71743 - LUA functions mw.wikibase.label and mw.wikibase.sitelink should not load the whole entity into memory
LUA functions mw.wikibase.label and mw.wikibase.sitelink should not load the ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
: need-volunteer
Depends on: 71169
Blocks: 73087
  Show dependency tree / graph
 
Reported: 2014-10-07 14:55 UTC by Sergey Vladimirov
Modified: 2014-11-12 11:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sergey Vladimirov 2014-10-07 14:55:43 UTC 
AFAIU current implementation of mw.wikibase.entity.lua implies loading of the whole entity into memory both for mw.wikibase.label() and mw.wikibase.sitelink() LUA functions. Using those functions 10 times on single pages means loading 10 enities to memory.

There should be 2 server-side (db-side? 10k limited memory-side?) caches Q->label and Q->sitelink for local language as most used ones. Those caches should be used instead of internal call to getEntityObject(), unless we checking the current entity.
Comment 1 Gerrit Notification Bot 2014-11-08 00:26:15 UTC 
Change 171992 had a related patch set uploaded by Hoo man:
Don't load the full entity into Lua to get labels/ sitelinks

https://gerrit.wikimedia.org/r/171992
Comment 2 Gerrit Notification Bot 2014-11-12 11:33:58 UTC 
Change 171992 merged by jenkins-bot:
Don't load the full entity into Lua to get labels/ sitelinks

https://gerrit.wikimedia.org/r/171992
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links