Last modified: 2014-10-01 17:05:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 71506 - False height of checkbox focus ::after
False height of checkbox focus ::after
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
1.25-git
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 69200
  Show dependency tree / graph
 
Reported: 2014-10-01 11:00 UTC by Florian
Modified: 2014-10-01 17:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
invalid negative height result in Google Chrome (8.77 KB, image/jpeg)
2014-10-01 11:00 UTC, Florian 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-10-01 11:00:53 UTC 
Created attachment 16638 [details]
invalid negative height result in Google Chrome

Line https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki.ui/components/checkbox.less#L85
of checkbox.less results in a negative value after the change to em value for @checkboxSize (Ia6adc4bda000508f14acf4214e778118efa35be0) which isn't a valid value (see attachment for result in Chrome, same in FF).

@focusBottomBorderSize: 3px;
@checkboxSize: 1.6em;

height: @checkboxSize - @focusBottomBorderSize + 1; -> -0.4em
Comment 1 Florian 2014-10-01 11:06:30 UTC 
P.S.: Can be reproduced on each wmf-wiki running 1.25wmf1 (testwiki, mediawiki, wikinews, wikisource, e.g.) on the login form, e.g.:
https://www.mediawiki.org/wiki/Special:UserLogin
Comment 2 Andre Klapper 2014-10-01 12:48:43 UTC 
Florian: As you marked this as blocking bug 38865, could you elaborate how severe the problem is, and which functionality this problem destroys from a user point of view?
Comment 3 Florian 2014-10-01 13:21:53 UTC 
(In reply to Andre Klapper from comment #2)
> Florian: As you marked this as blocking bug 38865, could you elaborate how
> severe the problem is, and which functionality this problem destroys from a
> user point of view?

Ugh, that's a fault. I forgot to emove the bug before saving. It's a problem of 1.25wmf1, but there is no functionality broken, so no blocking :)
Comment 4 Gerrit Notification Bot 2014-10-01 15:51:55 UTC 
Change 164092 had a related patch set uploaded by Florianschmidtwelzow:
Use ems instead of pixels for checkbox

https://gerrit.wikimedia.org/r/164092
Comment 5 Gerrit Notification Bot 2014-10-01 17:04:19 UTC 
Change 164092 merged by jenkins-bot:
Use ems instead of pixels for checkbox

https://gerrit.wikimedia.org/r/164092
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links