Last modified: 2014-11-11 09:46:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72909, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70909 - checkboxes hover, focus, and click states are not to spec
checkboxes hover, focus, and click states are not to spec
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://trello.com/c/JETLmm7F/7-check...
:
Depends on:
Blocks: 69200
  Show dependency treegraph
 
Reported: 2014-09-16 23:19 UTC by Jared Zimmerman (WMF)
Modified: 2014-11-11 09:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jared Zimmerman (WMF) 2014-09-16 23:19:09 UTC
currently checkboxes do not carry the bottom border on hover, only on focus. 

additionally when clicked (active) the bottom border disappears.

The check mark is only supposed to be green when the both checked and hovered 

border colors are inconsistent with unfocused input fields (too dark)
Comment 1 Gerrit Notification Bot 2014-09-18 16:43:24 UTC
Change 161261 had a related patch set uploaded by Prtksxna:
checkbox.less: images

https://gerrit.wikimedia.org/r/161261
Comment 2 Matthew Flaschen 2014-09-20 02:20:37 UTC
(In reply to Jared Zimmerman (WMF) from comment #0)
> currently checkboxes do not carry the bottom border on hover, only on focus. 

Can you update mw.ui.checkbox.fw.png at https://trello.com/c/JETLmm7F/7-check-boxes ?  Currently it doesn't mention hover at all.

It would be good to visually distinguish between the hover and focus states.

> additionally when clicked (active) the bottom border disappears.

I assume active is the same as focused.

> The check mark is only supposed to be green when the both checked and
> hovered 

The mockup shows it green on focus.
Comment 3 Jared Zimmerman (WMF) 2014-09-20 21:23:33 UTC
focus = hover in this case. We're handling the keyboard/accessibility focus in a separate bug.
Comment 4 Gerrit Notification Bot 2014-11-11 09:46:07 UTC
Change 161261 abandoned by Prtksxna:
checkbox.less: Fix checkbox states

Reason:
Too out of date.

https://gerrit.wikimedia.org/r/161261

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links