Last modified: 2014-10-16 02:30:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72707, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70707 - editEntity using site object depends on py2.7
editEntity using site object depends on py2.7
Status: NEW
Product: Pywikibot
Classification: Unclassified
Wikidata (Other open bugs)
core-(2.0)
All All
: Lowest minor
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: py26
  Show dependency tree / graph
 
Reported: 2014-09-11 11:07 UTC by John Mark Vandenberg
Modified: 2014-10-16 02:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-09-11 11:07:16 UTC 
WikibasePage.toJSON depends on collections.Counter, which is only available in pu2.7.

WikibasePage.editEntity with data=None uses is the only current caller of WikibasePage.toJSON.   This is new functionality, unavailable in compat, so a py 2.7 requirement is not a breaking change.
Comment 1 Gerrit Notification Bot 2014-09-11 11:08:55 UTC 
Change 159700 had a related patch set uploaded by John Vandenberg:
Require 2.7+ for one wikibase test

https://gerrit.wikimedia.org/r/159700
Comment 2 Fabian 2014-09-11 11:11:34 UTC 
There is https://pypi.python.org/pypi/Counter/1.0.0 which could be used in 2.6 or we use the recipy directly http://code.activestate.com/recipes/576611-counter-class/
Comment 3 John Mark Vandenberg 2014-09-11 11:20:37 UTC 
Indeed.  Whereas we knew we needed a backport of OrderedDict for non-Wikibase needs, collections.Counter is so far only needed for Wikibase functionality not available previously or in compat, so we dont need to maintain backwards compatibility.  This bug is to ensure it can be found easily.  If there are py2.6 users of `core` needing this, we need to know who they are and why.
Comment 4 Gerrit Notification Bot 2014-09-11 19:22:55 UTC 
Change 159700 merged by jenkins-bot:
Require 2.7+ for one wikibase test

https://gerrit.wikimedia.org/r/159700
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links