Last modified: 2014-09-24 10:11:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72701, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70701 - Reference bars shouldn't have all styling done with JS
Reference bars shouldn't have all styling done with JS
Status: RESOLVED DUPLICATE of bug 52136
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-11 05:48 UTC by Yair Rand
Modified: 2014-09-24 10:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yair Rand 2014-09-11 05:48:25 UTC
A lot of stuff is done to the "# references" bars on items with javascript that could be done much more efficiently with CSS. 
1. JS adds this element to the DOM: 
<span class="ui-toggler-icon ui-icon ui-icon-triangle-1-s ui-toggler-icon3dtrans"></span>
and it does nothing more than add a little arrow image to the bar. CSS ::before generated content could be used instead. (If it weren't for the little rotate animation, this would ideally use a background image.)
2. .ui-toggler is constantly listening for mouseovers so that it can add the "ui-state-hover" class to style the little arrow. Solution: Use the :hover pseudoclass.
3. JS adds all sorts of classes all over the place to style it differently than how the JS-disabled users get. Solution: Use .client-js CSS to have it styled right in the first place.
There is no reason for JS to be fiddling with this bar at all unless the user actually clicks on it.
Comment 1 Lydia Pintscher 2014-09-24 10:11:09 UTC
Agreed. Going to mark this as a dupe of the UI redesign however as those things will be redone there.

*** This bug has been marked as a duplicate of bug 52136 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links