Last modified: 2014-10-21 12:55:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72617, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70617 - Displays <a href="#">another file</a> instead of a link to "the existing file".
Displays <a href="#">another file</a> instead of a link to "the existing file".
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.25-git
All All
: Normal normal (vote)
: 1.25.0 release
Assigned To: Santhosh Thottingal
: code-update-regression
: 59203 70639 71368 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-09 17:37 UTC by Jonatan Svensson Glad (Josve05a)
Modified: 2014-10-21 12:55 UTC (History)
22 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jonatan Svensson Glad (Josve05a) 2014-09-09 17:37:56 UTC 
Step 1. Go to https://commons.wikimedia.org/wiki/Special:UploadWizard
Step 2. Press "Share images from Flickr".
Step 3. Enter https://www.flickr.com/photos/statephotos/14950833937/ and press "Get from Flickr".

Expected result: there should be a hyperlink for the words "another file".

Actual result:It says: There is <a href="#">another file</a> already on the site with the same content.

I'm using
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0a1
AMD Radeon HD 7310 Graphics
Windows 8 64-bit, x64.
Comment 1 Marco 2014-09-23 22:31:32 UTC 
*** Bug 59203 has been marked as a duplicate of this bug. ***
Comment 2 Bartosz Dziewoński 2014-09-26 23:05:34 UTC 
Core bug caused by the fix for bug 69993.
Comment 3 Bartosz Dziewoński 2014-09-26 23:06:08 UTC 
*** Bug 70639 has been marked as a duplicate of this bug. ***
Comment 4 Bartosz Dziewoński 2014-09-26 23:07:44 UTC 
Test case for this bug: https://gerrit.wikimedia.org/r/#/c/162013/1
Comment 5 Bartosz Dziewoński 2014-09-26 23:10:56 UTC 
The patch that caused this (e16ca154f47b0d95060c9f7663c74fa11f848c09) was trying to solve the issue that {{PLURAL:N|1=a|2=b}} is not parsed as [['1', 'a'], ['2', 'b']], but rather ['1=a', '2=b'], which becomes a problem when '1=a' gets parsed and we can't un-parse it to pull out the number, and therefore parse the explicit plural forms.

It solved that by "flattening" nodes that are jQuery objects to HTML, which broke things for the normal case.

The best way to do this would be to extend the parser to support explicit parameters (good luck doing that, heh). A less bad way (than the current) would be to move the DOM object stringification to mw.language.convertPlural() and only do it when necessary (should be easy-ish).

Gilles, do you want to look into this?
Comment 6 Santhosh Thottingal 2014-09-29 06:34:20 UTC 
Patch: https://gerrit.wikimedia.org/r/#/c/163460/
Comment 7 Gerrit Notification Bot 2014-09-30 04:27:22 UTC 
Change 163460 had a related patch set uploaded by Santhosh:
mediawiki.jqueryMsg: Support arbitrary expressions in plural forms

https://gerrit.wikimedia.org/r/163460
Comment 8 Bartosz Dziewoński 2014-10-01 07:26:29 UTC 
Thanks Santhosh!
Comment 9 Gerrit Notification Bot 2014-10-01 07:32:03 UTC 
Change 163460 merged by jenkins-bot:
mediawiki.jqueryMsg: Support arbitrary expressions in plural forms

https://gerrit.wikimedia.org/r/163460
Comment 10 Santhosh Thottingal 2014-10-21 12:55:33 UTC 
*** Bug 71368 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links