Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71838, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69838 - apps/ios/wikipedia.git should pass JSHint code conventions

Summary:	apps/ios/wikipedia.git should pass JSHint code conventions

Status: NEW Product: Wikipedia App Classification: Unclassified Component: iOS App (Other open bugs) Version: Alpha Hardware: All All Importance: Unprioritized enhancement Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: jshint   Show dependency tree / graph		Reported: 2014-08-21 08:26 UTC by Antoine "hashar" Musso (WMF) Modified: 2014-08-21 08:37 UTC (History) CC List: 3 users (show) dgarry klans yuvipanda See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-08-21 08:26:15 UTC I found out apps/ios/wikipedia.git has some javascript files but running JSHint reports a bunch of errors. Would be nice to define a code convention and enforce it. The MediaWiki JavaScript code convention can be found at http://www.mediawiki.org/wiki/CC/JS Comment 1 Antoine "hashar" Musso (WMF) 2014-08-21 08:37:36 UTC The reason I am filling this bug is because I have added Jenkins jobs to lint the PHP and JS files ( https://gerrit.wikimedia.org/r/#/q/I2e480c1d6e74e24256ed4e0dc28f78e40e805a69,n,z ) Jshint does not pass https://integration.wikimedia.org/ci/job/apps-ios-wikipedia-jslint/1/console