Last modified: 2014-09-20 20:49:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71823, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69823 - BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in preferences
BetaFeatures: wgBetaFeaturesFeatures is incomplete, causing wrong UI in prefe...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Bartosz Dziewoński
:
Depends on: 70814
Blocks: 70371
  Show dependency treegraph
 
Reported: 2014-08-21 00:43 UTC by Matthew Flaschen
Modified: 2014-09-20 20:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-08-21 00:43:27 UTC
I'm not sure why, but wgBetaFeaturesFeatures is incomplete on my local MediaWiki-Vagrant install.

In the actual preferences UI, I see the following BetaFeatures:

* Hovercards
* Compact personal bar
* Fixed header
* VisualEditor
* VisualEditor language tool

But wgBetaFeaturesFeatures is only:

{ popups: null, visualeditor-enable-language: null }

That in turn means that these are the only ones looped over in betafeatures.js, which means other features don't have the JavaScript/browser blacklist processing.

This bug affects production as well.

Side note, you can use:

.client-js .mw-ui-feature-requirements-javascript {
  display: none;
}

for a simpler way to do the JS-hiding, but that doesn't address the underlying problem.
Comment 1 Gerrit Notification Bot 2014-09-10 20:04:59 UTC
Change 159538 had a related patch set uploaded by Jforrester:
Populate $features even if there aren't any requirements

https://gerrit.wikimedia.org/r/159538
Comment 2 Seb35 2014-09-18 23:18:11 UTC
This bug is a consequence of bug 70814, see https://bugzilla.wikimedia.org/show_bug.cgi?id=70814#c5 : the fix there correctly populates the wgBetaFeaturesFeatures array. (I make this bug depend of bug 70814, but it is similar to a duplicate.)
Comment 3 Seb35 2014-09-19 23:47:25 UTC
https://gerrit.wikimedia.org/r/161629 should have resolved this bug. Is it confirmed?
Comment 4 Seb35 2014-09-19 23:49:47 UTC
Ah, sorry. I meant https://gerrit.wikimedia.org/r/160213.
Comment 5 Gerrit Notification Bot 2014-09-20 18:30:19 UTC
Change 159538 merged by jenkins-bot:
Populate $features even if there aren't any requirements

https://gerrit.wikimedia.org/r/159538
Comment 6 Bartosz Dziewoński 2014-09-20 18:32:37 UTC
Underlying issue is only fixed by James's patch, but Seb35's patch has already fixed the display for the beta features I tested.
Comment 7 Bartosz Dziewoński 2014-09-20 18:37:54 UTC
(In reply to Matthew Flaschen from comment #0)
> Side note, you can use:
> 
> .client-js .mw-ui-feature-requirements-javascript {
>   display: none;
> }
> 
> for a simpler way to do the JS-hiding, but that doesn't address the
> underlying problem.

Done in https://gerrit.wikimedia.org/r/161690

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links