Last modified: 2014-08-25 03:50:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71809, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69809 - Recommendations personal tool is dead link for no-JS or unsupported browsers
Recommendations personal tool is dead link for no-JS or unsupported browsers
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Rob Moen
:
Depends on:
Blocks: 69845
  Show dependency tree / graph
 
Reported: 2014-08-20 20:24 UTC by Matthew Flaschen
Modified: 2014-08-25 03:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-08-20 20:24:15 UTC 
For users without JavaScript or in IE 7, the personal tool will be a dead link.  It shows, but does nothing except change URL to #recommendations on click.

It needs to be hidden by default, then conditionally shown if it's a supported browser.  That should also take care of the no-JS case (If/when we support IE 7, we can switch to the 'client-nojs' class for this, which goes on the body and is removed by JS).
Comment 1 Gerrit Notification Bot 2014-08-20 21:44:09 UTC 
Change 155447 had a related patch set uploaded by Robmoen:
Hide recommendations in personal tools if js is disabled

https://gerrit.wikimedia.org/r/155447
Comment 2 Gerrit Notification Bot 2014-08-24 04:19:07 UTC 
Change 155447 merged by jenkins-bot:
Add personal tool styles on personal urls hook

https://gerrit.wikimedia.org/r/155447
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links