Last modified: 2014-08-28 20:24:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71159, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69159 - sorting of style modules leading to arbitrary loading of files
sorting of style modules leading to arbitrary loading of files
Status: RESOLVED DUPLICATE of bug 45229
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-06 00:32 UTC by Moka
Modified: 2014-08-28 20:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Moka 2014-08-06 00:32:14 UTC 
The order of how CSS files is important. I would argue the order in which style modules are added to the resource loader should be maintained, but it is not (see https://git.wikimedia.org/blob/mediawiki%2Fcore.git/02936f3d9541f524c82283bb81b3c1e57816ce71/includes%2FOutputPage.php#L2710). 'dependencies' also does not work for style modules. Please either allow style modules to be dependent on other modules or take out the sort.
Comment 1 Andre Klapper 2014-08-06 13:34:07 UTC 
(In reply to Moka from comment #0)
> The order of how CSS files is important. [...]
> 'dependencies' also does not work for style modules.

Is there a specific example that you could share?
Comment 2 Moka 2014-08-06 22:03:07 UTC 
(In reply to Andre Klapper from comment #1)
> (In reply to Moka from comment #0)
> > The order of how CSS files is important. [...]
> > 'dependencies' also does not work for style modules.
> 
> Is there a specific example that you could share?

Here are the contents of my skin:


skins/TLKWiki/TLKWiki.php
https://ghostbin.com/paste/zaonx

skins/TLKWiki/SkinTLKWiki.php
https://ghostbin.com/paste/uzdp4

skins/TLKWiki/screen.css
(some CSS file)

Here is a link to my wiki http://www.mylionking.com/wiki
I have removed the sort() on the line I linked to in the first post.
Comment 3 Bartosz Dziewoński 2014-08-28 20:24:41 UTC 

*** This bug has been marked as a duplicate of bug 45229 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links