Last modified: 2014-08-21 22:51:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70424, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68424 - Installed skins on Special:Version should show a version in Wikimedia envionment (from git)


Summary:	Installed skins on Special:Version should show a version in Wikimedia envionm...

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Deployment systems (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low enhancement (vote)
Target Milestone:	---
Assigned To:	Bryan Davis

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	68333
	Show dependency tree / graph

Reported:	2014-07-23 08:23 UTC by db [inactive,noenotif]
Modified:	2014-08-21 22:51 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2014-07-23 08:23:40 UTC

Special:Version shows the git hash and timestamp for all the extensions, but the installed skins does not have a timestamp, except for CologneBlue and Modern there should be a git hash. Vector and Monobook can not have one, because there are part of core.

http://en.wikipedia.org/wiki/Special:Version#mw-version-skin

Comment 1 Bartosz Dziewoński 2014-07-23 12:56:14 UTC

Works for me locally. Must be a WMF misconfiguration or something.

Comment 2 Bartosz Dziewoński 2014-07-23 13:00:52 UTC

Perhaps this has something to do with the precomputing of this information in WMF environment? https://gerrit.wikimedia.org/r/#/c/130498/ But I have no idea where the code that does the precomputing is located.

Comment 3 Bartosz Dziewoński 2014-07-23 13:04:40 UTC

Nevermind, found it, and it indeed only handles the extensions/ directory and not skins/. https://gerrit.wikimedia.org/r/#/c/130560/

Comment 4 Gerrit Notification Bot 2014-08-09 17:29:15 UTC

Change 153127 had a related patch set uploaded by Bartosz Dziewoński:
Precompute data for GitInfo for skins, too

https://gerrit.wikimedia.org/r/153127

Comment 5 db [inactive,noenotif] 2014-08-16 19:31:18 UTC

The patch does not help here (or it is not the last action to do)

Comment 6 Bartosz Dziewoński 2014-08-16 20:16:00 UTC

I'm pretty sure that it does. We'll only know for sure if somebody decides to actually review and maybe deploy it.

Comment 7 Gerrit Notification Bot 2014-08-21 22:50:50 UTC

Change 153127 merged by jenkins-bot:
Precompute data for GitInfo for skins, too

https://gerrit.wikimedia.org/r/153127

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links