Last modified: 2014-07-21 21:26:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70155, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68155 - remove badges when changing the sitelink on the repo
remove badges when changing the sitelink on the repo
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=3 s=2014-07-15
:
Depends on:
Blocks: 40810
  Show dependency tree / graph
 
Reported: 2014-07-17 10:51 UTC by Lydia Pintscher
Modified: 2014-07-21 21:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lydia Pintscher 2014-07-17 10:51:52 UTC 
Currently the sitelink's badge is kept when changing the sitelink. We should change this when making the edit on the repo. The badge should be kept when moving the site on the client.

The following should happen when a user changes the sitelink on the repo:
* he deletes the old sitelink in the text field and starts typing a new one
* the existing badges icon is turned into the placeholder icon that is also shown when no badge is set
* when pressing save the badge is removed in the database
Comment 1 Lydia Pintscher 2014-07-17 12:16:35 UTC 
Rationale: When changing the sitelink on the repo it is likely that the article is not the same and the badge is wrong for the new article. When moving the page on the client the article is likely the same and the badge should stay.
Comment 2 Gerrit Notification Bot 2014-07-21 17:37:09 UTC 
Change 148117 had a related patch set uploaded by Hoo man:
Remove badges if a sitelink is being changed in the UI

https://gerrit.wikimedia.org/r/148117
Comment 3 Gerrit Notification Bot 2014-07-21 21:26:37 UTC 
Change 148117 merged by jenkins-bot:
Remove badges if a sitelink is being changed in the UI

https://gerrit.wikimedia.org/r/148117
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links