Last modified: 2014-11-06 16:31:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70022, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68022 - Make formatter for referenced Items use pre-fetched labels.
Make formatter for referenced Items use pre-fetched labels.
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on: 68025
Blocks: 73087 68019
  Show dependency tree / graph
 
Reported: 2014-07-15 10:46 UTC by Daniel Kinzler
Modified: 2014-11-06 16:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-07-15 10:46:50 UTC 
When rendering links to referenced items in an EntityView, we should use pre-fetched labels from an EntityInfoBuilder, instead of loading each of the entities in full just to get the label.

However, EntityView resp. ClaimHtmlGenerator and related classes use a SnakFormatter for rendering snak values. The SnakFormatter is provided to EntityView via the constructor. 

We need to inject the information from the EntityInfoBuilder into the EntityIdHtmlLinkFormatters buried deep in the SnakFormatter.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links