Last modified: 2014-07-14 10:17:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 67938 - Block::newFromTarget gets autoblocks when its documentation says it doesn't
Block::newFromTarget gets autoblocks when its documentation says it doesn't
Status: NEW
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: documentation
  Show dependency treegraph
Reported: 2014-07-13 03:53 UTC by Jackmcbarn
Modified: 2014-07-14 10:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Jackmcbarn 2014-07-13 03:53:18 UTC
Block::newFromTarget returns autoblocks when its second parameter is null, even though its doc comment specifically says that it won't. This is dangerous because callers that believe the doc comment could end up leaking autoblocks. I'm not sure whether it's the code or the comment that's "right", though. See comments on I9ea77ae1ac31b44f2bb9767d41192dc0ae492c28

Note You need to log in before you can comment on or make changes to this bug.