Last modified: 2014-07-28 20:50:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69756, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67756 - Replace phpsh with hhvm repl
Replace phpsh with hhvm repl
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Ori Livneh
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-09 22:20 UTC by Bryan Davis
Modified: 2014-07-28 20:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-07-09 22:20:28 UTC
HHVM has a repl mode and phpsh is mostly abandonware.

[15:41]  <      ori>	 the hhvm repl is better than phpsh
[15:41]  <      ori>	 phpsh is dead, i've had to fork it to fix bugs
[15:41]  <      ori>	 i'm actually the maintainer of the package on pypi
[15:42]  <    bd808>	 Ok. So should we stop installing it? Or make it possible to tell it to run php5 instead?
[15:42]  <      ori>	 and it's also from facebook!
[15:42]  <    bd808>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=67746
[15:42]  <      ori>	 yeah, i saw
[15:42]  <    bd808>	 I can reproduce
[15:42]  <      ori>	 well, we need to work out how to invoke hhvm with mediawiki's codebase loaded
[15:42]  <      ori>	 then we can get rid of phpsh
Comment 1 Gerrit Notification Bot 2014-07-10 16:03:02 UTC
Change 145222 had a related patch set uploaded by BryanDavis:
[WIP] Enable HHVM debugging REPL

https://gerrit.wikimedia.org/r/145222
Comment 2 Gerrit Notification Bot 2014-07-14 04:07:39 UTC
Change 145222 merged by jenkins-bot:
Enable HHVM debugging REPL

https://gerrit.wikimedia.org/r/145222
Comment 3 Bryan Davis 2014-07-14 04:42:56 UTC
The HHVM debugging shell is now available within the guest VM. Use by 
logging in to your vm and running:

    hhvm --mode debug --debug-host ::1

Or use from the host computer with:

    vagrant ssh -c 'hhvm --mode debug --debug-host ::1'

Once connected, type '?' for a list of basic commands. For example, `g`
will list current globals or `=$IP` will show the current value of the
$IP variable.

We could probably make a tiny shell script (hhvmsh?) to fire up the debugger repl and then kill off phpsh or make it only install when the zend role is enabled.
Comment 4 Gerrit Notification Bot 2014-07-14 05:07:40 UTC
Change 146021 had a related patch set uploaded by BryanDavis:
Replace phpsh with "hhvmsh"

https://gerrit.wikimedia.org/r/146021
Comment 5 Gerrit Notification Bot 2014-07-15 03:56:43 UTC
Change 146021 merged by jenkins-bot:
Replace phpsh with "hhvmsh"

https://gerrit.wikimedia.org/r/146021

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links