Last modified: 2014-07-03 03:04:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69447, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67447 - VisualEditor: Link annotation gets cut off when label contains linktrail end characters
VisualEditor: Link annotation gets cut off when label contains linktrail end ...
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2014-07-03 01:10 UTC by Krinkle
Modified: 2014-07-03 03:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screen recording of bug (1.17 MB, video/quicktime)
2014-07-03 01:10 UTC, Krinkle
Details

Description Krinkle 2014-07-03 01:10:24 UTC
Created attachment 15828 [details]
Screen recording of bug

1. Edit page with a link is applied to multiple words in sequence.
   such as "QUnit - Foo bar baz".
2. Select part of it (e.g. "Foo bar baz")
3. Type something new (e.g. "Quux")

Expected:

Quux replaces "Foo bar baz" and is a link as well.

Actual:

The text is removed, the link now ends at "-" and the inserted text "Quux" is just plain unlinked text.

This might have to do with linktrail processing and the operation happening as separate delete/insert.


Video: http://cl.ly/2K1q1A471G2N
Comment 1 James Forrester 2014-07-03 02:14:52 UTC
You've failed to spot the key part of this – you have to select *to or past the end of the link*.

Selections from inside a whitespace-terminated annotation to outside it which replace into it with a whitespace character will terminate it. Selections from inside said annotation to another place inside it (in your example, "Foo bar ba" but not "Foo bar baz") don't.

This is intentional behaviour.
Comment 2 This, that and the other (TTO) 2014-07-03 02:32:15 UTC
(In reply to James Forrester from comment #1)
> This is intentional behaviour.

Doesn't it strike you as something a user may very legitimately and intuitively want to accomplish?
Comment 3 James Forrester 2014-07-03 03:04:04 UTC
(In reply to This, that and the other from comment #2)
> (In reply to James Forrester from comment #1)
> > This is intentional behaviour.
> 
> Doesn't it strike you as something a user may very legitimately and
> intuitively want to accomplish?

Yes. We spent months discussing this, looking at dozens of different rich editors' behaviours. That's why I'm reasonably confident that the answer is "tough".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links