Last modified: 2007-06-09 16:19:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8743, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 6743 - Make image links to image page, not to upload on upload disabled [Patch]


Summary:	Make image links to image page, not to upload on upload disabled [Patch]

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement with 4 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	6740 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-19 17:15 UTC by Platonides
Modified:	2007-06-09 16:19 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Linker patch (980 bytes, patch) 2006-07-19 17:39 UTC, Platonides	Details
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2006-07-19 17:15:00 UTC

If a image exist, it's a link to the image page. If a image doesn't exist, the
image link points to the upload page: "be bold and upload it!" Ok. But if you
don't allow uploading, it is unsense. So if a wiki have uploading disabled,
non-existant image links should point to the image page ('we have no such
image') instead of the upload page ('you can't upload, it's disabled') as the
user didn't ask for uploading an image, only followed an image link (which only
wikiholics understand as a link-to-upload).

Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-07-19 17:19:59 UTC

*** Bug 6740 has been marked as a duplicate of this bug. ***

Comment 2 Platonides 2006-07-19 17:39:27 UTC

Created attachment 2126 [details]
Linker patch

The patch (at r15726). Sorry for the duplicates. Bugzilla wasn't accepting the
post, and was giving 500s. It seems several passed :P

Comment 3 Nicholas Tung 2006-12-29 23:01:43 UTC

I don't know if you patched it incorrectly or what, but when I create a
[[:image:something]] in 1.6.8, it takes me to a "create a new page" instead of
the upload page. I have uploads enabled.

Comment 4 Nicholas Tung 2006-12-29 23:04:08 UTC

I get something like

/index.php?title=Image:imagename&action=edit

that is. if it were without the action=edit, it would work fine.

Comment 5 Rob Church 2007-06-09 16:19:46 UTC

Fixed in r22867.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links